Review main Merged

84532[TASK] Cleanup extbase persistence backend class

Torben Hansen CR +2 V +2 Hard +86 −165 updated 06/13/24, 17:49

Commit message

This change cleans up extbase persistence backend class, by:

* using constructor property promotion
* using strict types and return types where possible
* removing self explaining method doc comments

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 710

  1. Torben Hansen uploaded patch set 1 06/08/24, 17:05

  2. core-ci voted on patch set 1 V +1 06/08/24, 17:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58920

  3. Benni Mack voted on patch set 1 CR +1 V +1 06/13/24, 16:02

  4. Christian Kuhn updated the commit message in patch set 2 CR +1 V +1 06/13/24, 16:06

  5. Christian Kuhn rebased onto patch set 3 06/13/24, 16:07

  6. core-ci voted on patch set 2 V +1 06/13/24, 16:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59509

  7. core-ci voted on patch set 3 V +1 06/13/24, 16:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59510

  8. Christian Kuhn voted on patch set 3 CR +1 V +1 06/13/24, 16:16

  9. Benni Mack voted on patch set 3 CR +2 V +2 06/13/24, 17:49

  10. Benni Mack merged patch set 4 06/13/24, 17:49