Review main Merged

84533[TASK] Add `phpunit 11.2.0` as conflict version due to regression

Stefan Bürk CR +2 V +2 Easy +11 −3 updated 06/09/24, 07:49

Commit message

PHPUnit refactored the double creation to support doubling
readonly classes [1], thus breaking classes where the class
constructor is called with constructor arguments, but calling
itself a class method which is mocked using the `onlyMethods()`
setup option. This leads now to some internal state setup issue
and is reported as `regression` [2] providing steps to reproduce
it.

This change adds `phpunit 11.2.0` as conflict to the monorepo
version to avoid using it in nightly tests for now, until a
proper regression fix has been implemented in phpunit.

Used command(s):

  \
    cat \
    <<< $(jq --indent 1 --tab \
      '."conflict" += {"phpunit/phpunit": "11.2.0"}' \
      composer.json) > composer.json \
    && Build/Scripts/runTests.sh -s composer -- update --lock

[1] https://github.com/sebastianbergmann/phpunit/pull/5804
[2] https://github.com/sebastianbergmann/phpunit/issues/5857

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Anja Leichsenring +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Anja Leichsenring +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 69

  1. Stefan Bürk uploaded patch set 1 06/08/24, 17:12

  2. core-ci voted on patch set 1 V +1 06/08/24, 17:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58922

  3. core-ci commented on patch set 1 06/08/24, 17:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58923

  4. Simon Schaufelberger updated the commit message in patch set 2 V +1 06/08/24, 19:27

  5. Simon Schaufelberger voted on patch set 2 CR +1 V +1 06/08/24, 19:29

  6. core-ci voted on patch set 2 V +1 06/08/24, 19:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58926

  7. Anja Leichsenring voted on patch set 2 CR +1 V +1 06/09/24, 05:27

  8. Stefan Bürk voted on patch set 2 CR +2 V +2 06/09/24, 07:49

  9. Stefan Bürk merged patch set 3 06/09/24, 07:49