Review main Abandoned

84536[BUGFIX] Scheduler Module - Misaligned checkbox on task list

Thomas Hohn CR 0 V 0 Easy +1 −1 updated 11/26/24, 14:38

Commit message

This patch adds a missing align-top to the mark-up for the
checkbox on the task list in the scheduler module.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 910

  1. Thomas Hohn uploaded patch set 1 06/09/24, 08:50

  2. core-ci voted on patch set 1 V +1 06/09/24, 08:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58954

  3. Riccardo De Contardi commented on patch set 1 V +1 06/09/24, 09:04

    tested on latest main
  4. Simon Schaufelberger voted on patch set 1 CR +1 V +1 06/09/24, 09:34

  5. Riccardo De Contardi commented on patch set 1 V 0 06/09/24, 09:40

    I feel sorry for not having seen it before; It looks like this patch goes on the opposite direction... https://forge.typo3.org/issues/100515
  6. Thomas Hohn commented on patch set 1 06/09/24, 09:50

    Reply

    Okay - should be kill this patch then?
  7. Riccardo De Contardi commented on patch set 1 06/09/24, 10:00

    Reply

    I don't know; I see there's a discussion going on the other patch... IMHO especially for high cells the vertically centered is worse; I'd ask @benjamin.kott@outlook.com
  8. Thomas Hohn commented on patch set 1 09/11/24, 05:43

    Reply Unresolved

    Should we kill this patch @benjamin.kott@outlook.com?
  9. Benni Mack updated the commit message in patch set 2 CR +1 V +1 10/18/24, 13:49

  10. Thomas Hohn abandoned the change 11/26/24, 14:38

    Missing feedback