Review main Merged

84538[BUGFIX] Prevent backend errors for invalid backend_layout config

Garvin Hicking CR +2 V +2 Easy +24 −2 updated 06/10/24, 20:55

Commit message

When the configuration for `mod.web_layout.BackendLayouts`
contains column definitions with an empty content, this
will make both the list view and the normal page view
in the backend fail.

This makes using the GUI editing of the 'backend_layout'
records impossible to be fixed/addressed.

This patch now does a more lax check on the
'columns.' array to prevent PHP error notices on
invalid array key access.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 79

  1. Garvin Hicking uploaded patch set 1 06/10/24, 09:51

  2. core-ci voted on patch set 1 V +1 06/10/24, 09:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58988

  3. Georg Ringer voted on patch set 1 CR +1 V +1 06/10/24, 10:23

  4. Andreas Wolf voted on patch set 1 CR +1 06/10/24, 15:11

  5. Christian Kuhn uploaded patch set 2 CR +1 V +1 06/10/24, 17:48

  6. Christian Kuhn voted on patch set 2 CR +2 V +2 06/10/24, 17:49

  7. Stefan Bürk voted on patch set 2 CR +1 V +1 06/10/24, 17:52

  8. core-ci voted on patch set 2 V +1 06/10/24, 18:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59068

  9. Christian Kuhn merged patch set 3 06/10/24, 20:55