84539[TASK] Reference column headings in grid cells of "Page" module
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
-
Verified V +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1926
Show 1 earlier messages
-
Christian Rath-Ulrich uploaded patch set 1 06/10/24, 10:42
-
core-ci voted on patch set 1 V +1 06/10/24, 10:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58990
-
Christian Rath-Ulrich uploaded patch set 2
V +106/10/24, 10:59 -
core-ci voted on patch set 2 V +1 06/10/24, 11:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58993
-
Georg Ringer voted on patch set 2 CR +1 V +1 07/16/24, 14:01
-
Jasmina Ließmann commented on patch set 2 07/18/24, 18:33
In my tests, there was no `{column.definition.identifier}`. If (alternatively) the column name is used, spaces are replaced with `%20` and case sensitivity is also taken into account. How about using `colPos` as variable instead? For example: ```<f:variable name=‘columnId’ value=‘col-{column.definition.colPos}’ />``` -
Patrick Schriner uploaded patch set 3
CR +1V +108/01/24, 18:32 -
core-ci voted on patch set 3 V -1 08/01/24, 18:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62606
-
Patrick Schriner rebased onto patch set 4
V -108/01/24, 18:54 -
core-ci voted on patch set 4 V +1 08/01/24, 19:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62609
-
Patrick Schriner commented on patch set 4 08/01/24, 19:04
Reply
Done -
Stefan Kapitza-Graetz voted on patch set 4 CR +1 V +1 08/01/24, 19:21
-
Jasmina Ließmann commented on patch set 5
CR +1V +108/01/24, 19:21Published edit on patch set 4. -
core-ci voted on patch set 5 V +1 08/01/24, 19:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62620
-
Stefan Kapitza-Graetz voted on patch set 5 CR +1 V +1 08/02/24, 12:29
-
Georg Ringer voted on patch set 5 CR +1 V +1 08/02/24, 12:34
-
Jasmina Ließmann commented on patch set 5 V -1 08/02/24, 12:40
If no colPos is defined for a column, the identifier is always "columnId-". If this occurs to multiple columns, the identifier is no longer unique. -
Jasmina Ließmann uploaded patch set 6
CR +1V +108/02/24, 13:31 -
Jasmina Ließmann commented on patch set 6 08/02/24, 13:35
Reply
I adjusted the patch and tested in "Language Comparison" and "Layout" submodules with editable and non-editable columns. -
core-ci voted on patch set 6 V +1 08/02/24, 13:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62733
-
Jasmina Ließmann uploaded patch set 7
V +108/02/24, 14:25 -
core-ci voted on patch set 7 V +1 08/02/24, 14:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62746
-
Christian Kuhn voted on patch set 7 CR +1 V +1 08/06/24, 10:11
-
Stefan Bürk voted on patch set 7 CR +1 V +1 08/06/24, 10:21
-
Christian Kuhn voted on patch set 7 CR +2 V +2 08/06/24, 10:29
-
Christian Kuhn merged patch set 8 08/06/24, 10:37