Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.

Review main Work in progress Orphaned

84540[WIP][BUGFIX] unify additionalAttributes for all includeCSS*/includeJS*

Markus Volkmer CR 0 V 0 Normal +149 −38 updated 06/11/24, 07:53

Commit message

In #91499 additional attributes were introduced to
includeJS, includeCSS and derived methods. But
they never worked the same way.
This patch will add the possibility to add
additional attributes to includeCSS* and
includeJS*Libs with an array of key/value-pairs
like already possible with includeJS and includeJSFooter.
Also introducing new parameter `additionalAttributes.`
as replacement for former `data.` which could be
misinterpreted in several ways:
- functionality is not only about data-attributes
- `include*.data.` is not about typoscript-getText

This way it is possible to deprecate and later
remove the way of just adding further attributes
with single key/value-pairs.
With adding further attributes only through a
defined array of keys/values it is also no longer
neccessary to cleanup keys in RequestHandler as
soon as the 'old' way is removed which could even
make it possible to generalize code further as
there are currently four blocks for js and two
blocks for css which do nearly the same stuff with
redundant code in RequestHandler and PageRenderer.

12.4 backport should be possible technically;
manual conflict resolving might be neccessary.
You can contact me for helping to backport.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 3
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/40/84540/3 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/40/84540/3 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V 0

    Imported before Forger kept the single votes, the next import adds them.

Issues 3

Files 3