Review main Abandoned

84543[BUGFIX] Add detailed title to new content element button

Christian Rath-Ulrich CR 0 V 0 Easy +19 −5 updated 12/18/24, 11:07

Commit message

The new content element button now has a detailed title attribute.
This will further clarify the function associated with
the button to the users, improving usability and assistive
technologies could leverage this title for better accessibility.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 3

Review log 1016

  1. Christian Rath-Ulrich uploaded patch set 1 06/10/24, 12:48

  2. core-ci voted on patch set 1 V +1 06/10/24, 12:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59010

  3. Jasmina Ließmann uploaded patch set 2 V +1 06/10/24, 16:04

  4. Andreas Nedbal commented on patch set 1 06/10/24, 16:04

    This looks fine! However, while testing I noticed that the topmost new content element button doesn't have a title at all, which looks a bit inconsistent while hovering over all of them.
  5. Jasmina Ließmann uploaded patch set 3 06/10/24, 16:05

  6. core-ci voted on patch set 2 V +1 06/10/24, 16:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59047

  7. core-ci voted on patch set 3 V +1 06/10/24, 16:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59049

  8. Jasmina Ließmann uploaded patch set 4 V +1 06/10/24, 16:28

  9. core-ci voted on patch set 4 V +1 06/10/24, 16:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59053

  10. Jasmina Ließmann uploaded patch set 5 V +1 06/10/24, 17:02

  11. Jasmina Ließmann uploaded patch set 6 06/10/24, 17:06

  12. core-ci voted on patch set 5 V +1 06/10/24, 17:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59057

  13. core-ci voted on patch set 6 V +1 06/10/24, 17:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59058

  14. Riccardo De Contardi commented on patch set 6 V +1 08/01/24, 15:57

    Tested on latest main. Just as a suggestion: what about changing the text into: Insert new content element after the content element "[TITLEOFTHECEIFPRESENT]" - ID:xxx - [CTYPE] (if no title: Insert new content element after the content element ID:xxx - [CTYPE]) or a shorter version: Insert new content element after "[TITLEOFTHECE]" - ID:xxx - [CTYPE] (just to avoid repeating 'content element' on the same phrase)
  15. Benni Mack updated the commit message in patch set 7 V +1 10/18/24, 13:40

  16. Oli Bartsch abandoned the change 12/18/24, 11:07

    I'm abandoning this since there's been no activity on this for several months. If you'd like to pick it up again in the future, feel free to restore it anytime. Thanks!