84545[BUGFIX] Change header tag in PaletteAndSingleContainer and adjust tab.html
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Benjamin Kott +1
- Benni Mack +1
-
Verified V +2 Done
- Oli Bartsch +2
- Benjamin Kott +1
- core-ci +1 CI
Issues 1
Files 5
- Build/Sources/Sass/component/_panel.scss+1 −0
- Build/Sources/Sass/typo3/_main_form.scss+1 −6
- typo3/sysext/backend/Classes/Form/Container/PaletteAndSingleContainer.php+1 −1
- typo3/sysext/backend/Resources/Private/Partials/ModuleTemplate/Tabs.html+1 −0
- typo3/sysext/backend/Resources/Public/Css/backend.css+2 −3
Review log 1012
-
Christian Rath-Ulrich uploaded patch set 1 06/10/24, 15:06
-
core-ci voted on patch set 1 V +1 06/10/24, 15:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59026
-
morgane garcia voted on patch set 1 CR +1 V +1 06/10/24, 17:47
-
Benni Mack commented on patch set 1 06/21/24, 09:48
The commit message states something like "visually hidden headers" - can you elaborate what that is? -
Christian Rath-Ulrich commented on patch set 1 06/21/24, 10:05
Reply
the part in the tab.html I add the title of the tab as h2 so the screen reader will notice it in the tree. For example, you have 3 tabs and in each tab a headline than the goal is to have a tree like tab 1 (h2) - 1 headline in tab 1 (h3) - 2 headline in tab 1 (h3) tab 2 (h2) - 1 headline in tab 2 (h3) - 2 headline in tab 2 (h3) tab 3 (h2) - 1 headline in tab 3 (h3) - 2 headline in tab 3 (h3) so its easier to understand that there is a connection between tab and tab contend -
Benjamin Kott commented on patch set 1 CR -1 06/21/24, 10:32
on it -
Benjamin Kott uploaded patch set 2
CR +1V +106/21/24, 11:02 -
Benjamin Kott voted on patch set 2 CR +1 V +1 06/21/24, 11:03
-
core-ci voted on patch set 2 V +1 06/21/24, 11:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59993
-
Benni Mack voted on patch set 2 CR +1 06/21/24, 11:22
-
Oli Bartsch voted on patch set 2 CR +2 V +2 06/21/24, 11:39
-
Oli Bartsch merged patch set 3 06/21/24, 11:39