Review main Merged

84545[BUGFIX] Change header tag in PaletteAndSingleContainer and adjust tab.html

Christian Rath-Ulrich CR +2 V +2 Easy +6 −10 updated 06/21/24, 11:39

Commit message

This commit fixes a minor issue where the header
tag in PaletteAndSingleContainer was incorrectly
set as h4. The tag has been changed to h3 for
better readability and semantics. Simultaneously,
visually hidden headers were also added to tabs to
improve accessibility.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Benjamin Kott +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Benjamin Kott +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1012

  1. Christian Rath-Ulrich uploaded patch set 1 06/10/24, 15:06

  2. core-ci voted on patch set 1 V +1 06/10/24, 15:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59026

  3. morgane garcia voted on patch set 1 CR +1 V +1 06/10/24, 17:47

  4. Benni Mack commented on patch set 1 06/21/24, 09:48

    The commit message states something like "visually hidden headers" - can you elaborate what that is?
  5. Christian Rath-Ulrich commented on patch set 1 06/21/24, 10:05

    Reply

    the part in the tab.html I add the title of the tab as h2 so the screen reader will notice it in the tree. For example, you have 3 tabs and in each tab a headline than the goal is to have a tree like tab 1 (h2) - 1 headline in tab 1 (h3) - 2 headline in tab 1 (h3) tab 2 (h2) - 1 headline in tab 2 (h3) - 2 headline in tab 2 (h3) tab 3 (h2) - 1 headline in tab 3 (h3) - 2 headline in tab 3 (h3) so its easier to understand that there is a connection between tab and tab contend
  6. Benjamin Kott commented on patch set 1 CR -1 06/21/24, 10:32

    on it
  7. Benjamin Kott uploaded patch set 2 CR +1 V +1 06/21/24, 11:02

  8. Benjamin Kott voted on patch set 2 CR +1 V +1 06/21/24, 11:03

  9. core-ci voted on patch set 2 V +1 06/21/24, 11:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59993

  10. Benni Mack voted on patch set 2 CR +1 06/21/24, 11:22

  11. Oli Bartsch voted on patch set 2 CR +2 V +2 06/21/24, 11:39

  12. Oli Bartsch merged patch set 3 06/21/24, 11:39