Review 12.4 Merged

84553[BUGFIX] Omit wrong value on inserting record

Oli Bartsch CR +2 V +2 Easy +2 −2 updated 06/11/24, 08:39

Commit message

When inserting a record via the element
browser, the value argument needs either
to be formatted manually or left empty,
allowing the element browser to format
the identifier automatically.

By omitting the value in the `PageBrowser`
module, the value is now correctly formatted
by the element browser to "pages_<uid>".

This makes the "node-action" usable for
TCA group fields, which allow more than
one record type.

The same logic is also used by the
`BrowseDatabase` module, which also
omits the value argument.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 68

  1. Oli Bartsch commented on patch set 1 06/10/24, 16:30

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/backend/Resources/Public/JavaScript/tree/page-browser.js
  2. Oli Bartsch uploaded patch set 2 06/10/24, 16:36

  3. Oli Bartsch marked it ready for review 06/10/24, 16:36

  4. core-ci voted on patch set 1 V -1 06/10/24, 16:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59054

  5. core-ci voted on patch set 2 V +1 06/10/24, 16:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59055

  6. Oli Bartsch voted on patch set 2 CR +2 V +2 06/10/24, 16:43

  7. Oli Bartsch merged patch set 3 06/10/24, 16:43

  8. Andreas Kießling commented on patch set 3 06/11/24, 08:39

    Hey, thanks for taking care of this one! My client initially reported this for v11 but i selected v12 when i reported it :/ Is there any chance to get a backport of the fix for v11? For PHP code i'd do a composer patch, but with the TS build setup i have no idea on how to accomplish that.