Review main Merged

84574[DOCS] Correct information about slug postModifiers

Georg Ringer CR +2 V +2 Easy +1 −1 updated 06/13/24, 13:34

Commit message

The key `record` might not always contain the full record. When using the
`FormSlugAjaxController`, the record might just contain a sub-set of
fields.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 911

  1. Georg Ringer uploaded patch set 1 06/10/24, 19:02

  2. Georg Ringer commented on patch set 1 06/10/24, 19:02

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 06/10/24, 19:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59072

  4. Garvin Hicking updated the commit message in patch set 2 V +1 06/10/24, 19:16

  5. Garvin Hicking commented on patch set 2 06/10/24, 19:17

    (I'm not sure though that old Changelogs will get rendered in their original instance - so this change might only show up when viewing this changelog entry on the v11-13 rendered docs)
  6. Garvin Hicking commented on patch set 2 06/10/24, 19:18

    Feature-88198-TCA-basedSlugModifiersForExtensions.rst:39

    "based on" instead of "differ from"?
  7. core-ci voted on patch set 2 V +1 06/10/24, 19:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59073

  8. Garvin Hicking commented on patch set 2 CR +1 V +1 06/13/24, 12:15

    I think we could just merge it, even if it never gets rendered ¯\_(ツ)_/¯

    Feature-88198-TCA-basedSlugModifiersForExtensions.rst:39 Reply

    Reading it again it works for me
  9. Benni Mack voted on patch set 2 CR +1 V +1 06/13/24, 12:42

  10. Christian Kuhn voted on patch set 2 CR +2 V +2 06/13/24, 12:47

  11. Christian Kuhn merged patch set 3 06/13/24, 13:34