Review main Merged

84575[BUGFIX] Return an OK message if permissions are already fine

Georg Ringer CR +2 V +2 Easy +5 −8 updated 06/20/24, 13:15

Commit message

If the permissions are already ok, better return an OK FlashMessage
instead of throwing an exception.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jasmina Ließmann +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jasmina Ließmann +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1215

  1. Georg Ringer uploaded patch set 1 06/10/24, 20:33

  2. Georg Ringer commented on patch set 1 06/10/24, 20:33

    This change is ready for review.
  3. core-ci voted on patch set 1 V -1 06/10/24, 20:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59075

  4. Georg Ringer uploaded patch set 2 V -1 06/10/24, 21:34

  5. core-ci voted on patch set 2 V +1 06/10/24, 21:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59080

  6. Christian Kuhn commented on patch set 2 CR +1 V +1 06/20/24, 11:41

    this is fine, but found another issue in ext:install UI with fix permission in v13 -> new issue.
  7. Christian Kuhn commented on patch set 2 06/20/24, 11:51

  8. Jasmina Ließmann voted on patch set 2 CR +1 V +1 06/20/24, 11:52

  9. Andreas Kienast commented on patch set 2 CR -1 06/20/24, 12:04

    AbstractNode.php:149

    The grammar is broken (was already before). Either "Permissions are ok" or "Permission is ok".
  10. Georg Ringer uploaded patch set 3 CR +1 V +1 06/20/24, 12:44

  11. Christian Kuhn commented on patch set 3 CR +1 V +1 06/20/24, 12:48

    AbstractNode.php:149 Reply

    Done
  12. Jasmina Ließmann voted on patch set 3 CR +1 V +1 06/20/24, 12:49

  13. core-ci voted on patch set 3 V +1 06/20/24, 12:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59913

  14. Christian Kuhn voted on patch set 3 CR +2 V +2 06/20/24, 13:07

  15. Christian Kuhn merged patch set 4 06/20/24, 13:15