Review main Merged

84576[BUGFIX] Use correct column and index name caseing for PostgresSQL

Stefan Bürk CR +2 V +2 Easy +10 −8 updated 06/13/24, 13:51

Commit message

Doctrine DBAL uses lowercased array index names for
table or index names, which has been used to make
RENAME DDL statements. Due to the lack of having the
old information correctly in place, this leads to
invalid RENAME DDL statements for tables or indexes
having upper case characters in the name. That is a
edgecase for PostgreSQL and SQLite due to custom
index name handling based on that array key.

This change modifies the ConnectionMigrator to use
correct casing for column and index naming in case
table or column needs to be renamed.

That allows, that following correct DDL statements
are now created:

  ALTER INDEX "freeIndexUid_65098221"
    RENAME TO "customFreeIndexUid_6dedc8fa"

  ALTER TABLE "index_phash"
    RENAME COLUMN "freeIndexSetId" TO "zzz_deleted_freeIndexSetId"

in case the `EXT:indexed_search/ext_tables.sql` is changed
for table `index_phash` to drop the `freeIndexSetId` column
by commenting it out or remove it and renaming `freeIndexUid`
index to `customFreeIndexUid`. [1]

[1] https://review.typo3.org/c/Packages/TYPO3.CMS/+/84576/3/typo3/sysext/indexed_search/ext_tables.sql

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1015

  1. Stefan Bürk uploaded patch set 1 06/10/24, 21:22

  2. core-ci voted on patch set 1 V -1 06/10/24, 21:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59079

  3. Stefan Bürk uploaded patch set 2 V -1 06/11/24, 08:22

  4. core-ci voted on patch set 2 V +1 06/11/24, 08:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59131

  5. Stefan Bürk uploaded patch set 3 V +1 06/11/24, 08:45

  6. core-ci voted on patch set 3 V -1 06/11/24, 08:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59136

  7. Stefan Bürk uploaded patch set 4 V -1 06/11/24, 08:55

  8. core-ci voted on patch set 4 V +1 06/11/24, 09:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59139

  9. Stefan Bürk updated the commit message in patch set 5 V +1 06/12/24, 07:06

  10. core-ci voted on patch set 5 V +1 06/12/24, 07:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59279

  11. Andreas Kienast voted on patch set 5 CR +1 06/12/24, 07:56

  12. Christian Kuhn voted on patch set 5 CR +1 V +1 06/13/24, 12:32

  13. Andreas Kienast voted on patch set 5 V +1 06/13/24, 12:43

  14. Stefan Bürk voted on patch set 5 CR +2 V +2 06/13/24, 12:59

  15. Stefan Bürk merged patch set 6 06/13/24, 13:51