Review 11.5 Merged

84592[BUGFIX] Do not crash linkvalidator report with missing TCA field label

Christian Weiske CR +2 V +2 Easy +1 −1 updated 06/11/24, 06:46

Commit message

The mask extension[1] automatically generates column definitions in TCA,
and they do not have a 'label' key in the TCA columns definition.

In TYPO3 v11.5.37, the link validator report page crashes with the
following error:
> (1/1) #1476107295 TYPO3\CMS\Core\Error\Exception
> PHP Warning: Undefined array key "label"
> in [...]/linkvalidator/Classes/Report/LinkValidatorReport.php line 559

In TYPO3 v12 the problem does not occur anymore.

This patch simply checks if the label key exists before it is used.

[1] https://github.com/Gernott/mask

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 45

  1. Christian Weiske uploaded patch set 1 06/11/24, 05:45

  2. core-ci voted on patch set 1 V +1 06/11/24, 05:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59108

  3. Christian Weiske commented on patch set 1 06/11/24, 06:45

    Should I directly add support for columnsOverrides labels, or is that out of scope for a bugfix release?
  4. Stefan Bürk voted on patch set 1 CR +2 V +2 06/11/24, 06:46

  5. Stefan Bürk merged patch set 2 06/11/24, 06:46