Review main Merged

84596[BUGFIX] Show element specific labels in linkvalidator report

Christian Weiske CR +2 V +2 Easy +7 −5 updated 06/13/24, 11:12

Commit message

The link validator "missing links" report shows the title of the
field which contains the missing link.

This title is loaded from `TCA.$table.columns.$field.label`,
but it is possible to use content-element specific labels in
`TCA.$table.types.$contenttype.columnsOverrides.*.label`,
and this is not supported by the validator.

The patch first tries to load the overridden label and
then falls back to the normal TCA column label.

This fixes titles of elements generated by the "mask" extension,
which only sets labels via overrides.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Mogens Fiebrandt +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Mogens Fiebrandt +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1015

  1. Christian Weiske uploaded patch set 1 06/11/24, 07:31

  2. core-ci voted on patch set 1 V -1 06/11/24, 07:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59115

  3. Christian Weiske updated the commit message in patch set 2 V -1 06/11/24, 07:42

  4. Christian Weiske uploaded patch set 3 06/11/24, 07:43

  5. core-ci voted on patch set 2 V -1 06/11/24, 07:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59116

  6. core-ci voted on patch set 3 V +1 06/11/24, 07:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59117

  7. Christian Weiske uploaded patch set 4 V +1 06/12/24, 07:32

  8. core-ci voted on patch set 4 V +1 06/12/24, 07:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59283

  9. Mogens Fiebrandt voted on patch set 4 CR +1 V +1 06/13/24, 00:03

  10. Christian Kuhn updated the commit message in patch set 5 CR +1 V +1 06/13/24, 09:42

  11. Christian Kuhn commented on patch set 5 06/13/24, 09:42

    removed v11 from releases list: too late, not important enough.
  12. core-ci voted on patch set 5 V +1 06/13/24, 09:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59445

  13. Mogens Fiebrandt voted on patch set 5 CR +1 V +1 06/13/24, 10:14

  14. Christian Kuhn voted on patch set 5 CR +2 V +2 06/13/24, 10:46

  15. Christian Kuhn merged patch set 6 06/13/24, 11:12