Review main Abandoned

84601[WIP][TASK] Remove orphaned language keys

Jasmina Ließmann CR 0 V 0 Hard +2 −847 updated 01/15/26, 12:27

Commit message

Review

  • Code review CR 0
  • Verified V 0
    • core-ci +1 CI

Files 15

Review log 1519

  1. Jasmina Ließmann uploaded patch set 1 06/11/24, 08:07

  2. core-ci voted on patch set 1 V +1 06/11/24, 08:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59126

  3. Jasmina Ließmann uploaded patch set 2 V +1 06/11/24, 14:00

  4. core-ci voted on patch set 2 V +1 06/11/24, 14:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59197

  5. Georg Ringer commented on patch set 2 06/11/24, 14:42

    I want to avoid that IMHO now as it is IMHO not really known what is API and what not. I really love to take strings from the core because those are already translated. we need to first decide what is public API and what is internal and afterwards we can cleanup.
  6. morgane garcia voted on patch set 2 CR +1 V +1 06/11/24, 14:44

  7. Jasmina Ließmann commented on patch set 2 06/11/24, 14:51

    Reply

    Do you mean generally or just for individual xlf files or keys?
  8. Georg Ringer commented on patch set 2 06/11/24, 16:23

    Reply

    generally. we don't have IMHO any rules and it is a pitty for ext devs to adopt to xlf changes cause those sometimes "just vanish" as cleanup.
  9. Jasmina Ließmann uploaded patch set 3 CR +1 V +1 06/11/24, 16:27

  10. core-ci voted on patch set 3 V +1 06/11/24, 16:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59213

  11. Jasmina Ließmann uploaded patch set 4 V +1 06/13/24, 10:12

  12. Christian Kuhn commented on patch set 4 06/13/24, 10:17

    Reply

    We're removing unused labels from .xlf files for various versions already, there is no 'don't do it, if' rule. We could eventually argue about "global" files like locallang_general.xlf, but making these API would also lead to quite some trouble for core maintenance. With current 'living practice', I think we should definitely continue to remove unused labels from core. What do you think?
  13. Christian Kuhn commented on patch set 4 06/13/24, 10:19

    Reply Unresolved

    i think we should split the patch anyways: we can extract removals from definitely "specific" files like mod_web_list.xlf and similar already, since those cases are undisputable?
  14. core-ci voted on patch set 4 V +1 06/13/24, 10:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59456

  15. Andreas Kienast commented on patch set 4 06/13/24, 12:48

    locallang_login.xlf:36

    Reject modernity, embrace tradition.
  16. Jasmina Ließmann wrote 12/18/24, 11:21

    Removed cc Andreas Kienast.
  17. Jasmina Ließmann wrote 12/18/24, 11:21

    Set private
  18. Jasmina Ließmann wrote 10/29/25, 10:00

    Unset private
  19. Jasmina Ließmann abandoned the change 01/15/26, 12:27