Review main Merged

84602[TASK] Use multi record selection in SelectCheckBoxElement

Oli Bartsch CR +2 V +2 Normal +61 −126 updated 06/12/24, 07:37

Commit message

To unify and streamline record selection in the
backend, the SelectCheckBoxElement now also
utilizes the MultiRecordSelection component.

This allows to get rid of the custom JS implementation.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Andreas Nedbal +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Andreas Nedbal +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1521

  1. Oli Bartsch uploaded patch set 1 06/11/24, 08:14

  2. Oli Bartsch uploaded patch set 2 06/11/24, 08:18

  3. core-ci voted on patch set 1 V +1 06/11/24, 08:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59129

  4. core-ci voted on patch set 2 V +1 06/11/24, 08:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59130

  5. Jasmina Ließmann uploaded patch set 3 V +1 06/11/24, 08:57

  6. Jasmina Ließmann uploaded patch set 4 06/11/24, 08:58

  7. Jasmina Ließmann voted on patch set 4 CR +1 V +1 06/11/24, 09:01

  8. core-ci voted on patch set 3 V +1 06/11/24, 09:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59140

  9. core-ci voted on patch set 4 V +1 06/11/24, 09:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59141

  10. Andreas Nedbal voted on patch set 4 CR +1 V +1 06/11/24, 09:36

  11. Andreas Kienast voted on patch set 4 CR +2 V +2 06/11/24, 09:39

  12. Andreas Kienast commented on patch set 4 CR -2 06/11/24, 10:04

    Waiting for another feature @bo@cedev.de is building right now
  13. Oli Bartsch updated the commit message in patch set 5 CR +1 V +1 06/11/24, 17:51

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  14. Andreas Kienast voted on patch set 5 CR 0 06/11/24, 17:53

  15. core-ci voted on patch set 5 V +1 06/11/24, 17:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59226

  16. Garvin Hicking updated the commit message in patch set 6 V +1 06/11/24, 19:47

  17. core-ci voted on patch set 6 V +1 06/11/24, 19:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59247

  18. Andreas Nedbal voted on patch set 6 CR +1 V +1 06/12/24, 07:13

  19. Andreas Kienast voted on patch set 6 CR +1 V +1 06/12/24, 07:29

  20. Oli Bartsch voted on patch set 6 CR +2 V +2 06/12/24, 07:37

  21. Oli Bartsch merged patch set 7 06/12/24, 07:37