Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.

Review main Ready for review Stale

84603[TASK] Change typoscript from code to a data cache

Rasmus Salling CR 0 V 0 Normal +63 −75 updated 06/18/26, 23:07

Commit message

This modifies to typoscript cache from using PhpFrontend to FrontendInterface
and modifies it to use get instead of require.

This change makes it possible to use other storage mechanisms
including compression and alternative serialization like igbinary or similar.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 6
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/03/84603/6 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/03/84603/6 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V 0 Needs a vote
    • core-ci +1 CI

Issues 1

Files 12

Review log 1218

  1. Rasmus Salling uploaded patch set 1 06/11/24, 08:31

  2. core-ci voted on patch set 1 V -1 06/11/24, 08:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59133

  3. Rasmus Salling uploaded patch set 2 V -1 06/11/24, 08:44

  4. Rasmus Salling uploaded patch set 3 06/11/24, 08:47

  5. core-ci voted on patch set 2 V -1 06/11/24, 08:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59135

  6. core-ci voted on patch set 3 V -1 06/11/24, 08:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59137

  7. Rasmus Salling commented on patch set 3 06/11/24, 08:58

    Hmmm... Are those postgres specific tests failing? That seems somewhat curious.
  8. Stefan Bürk commented on patch set 3 06/11/24, 09:16

    Reply

    Check the error logs. There are PHP errors due to your change: > TypeError: TYPO3\CMS\Core\TypoScript\IncludeTree\TsConfigTreeBuilder::getSitePageTsConfigTree(): Return value must be of type array, string returned, in file /builds/typo3/CI/cms/typo3/sysext/core/Classes/TypoScript/IncludeTree/TsConfigTreeBuilder.php:250 and others.
  9. Rasmus Salling uploaded patch set 4 V -1 06/11/24, 09:37

  10. core-ci voted on patch set 4 V -1 06/11/24, 09:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59146

  11. Rasmus Salling uploaded patch set 5 V -1 06/11/24, 09:57

  12. core-ci voted on patch set 5 V +1 06/11/24, 10:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59155

  13. Andreas Kienast updated the commit message in patch set 6 V +1 06/11/24, 10:23

  14. core-ci voted on patch set 6 V +1 06/11/24, 10:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59160

  15. Christian Kuhn commented on patch set 6 CR -1 06/11/24, 13:13

    I don't think we should change this at the moment since I'm currently preparing a cache-layer change with other patches that will hopefully allow us to create smaller sized files together with quicker loading in the end.
  16. Rasmus Salling commented on patch set 6 06/11/24, 14:39

    Reply

    Thank you Stefan, been a while since I last contributed. Tests are passing now.

    Reply

    I'm really targeting this for the 13 LTS, so I'm fine with delaying this and/or looking at alternative solutions. For now we'll probably have to monkeypatch v12 for our own usecase since the v12 mechanism generates way too large cache files for our ~3000 typo3 installations, our combined typoscript cache size would hit atleast 30GB if we go live as-is, and I don't really see a change like this being backported to v12. In any case, would you be good with me resubmitting this after your changes, in case it still seems relevant? Conceptually it is hard to see why the typoscript cache should be a code cache, with all the limitations it imposes. Do you have an issue id on your efforts, so I can track it?
  17. Benni Mack wrote 04/11/25, 21:17

    Hashtag added: lolli-feedback
  18. Christian Kuhn wrote 06/18/26, 23:07

    Removed reviewer Christian Kuhn with the following votes: * Code-Review-1 by Christian Kuhn