Review main Merged

84604[TASK] Rename Access module to Permissions

morgane garcia CR +2 V +2 Easy +21 −2 updated 06/12/24, 08:31

Commit message

Currently module is nammed Access we change
to Permissions to be consistent to all the the backend

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Jasmina Ließmann +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Jasmina Ließmann +1
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 2736

Show 711 earlier messages
  1. morgane garcia uploaded patch set 1 06/11/24, 08:38

  2. Mathias Brodala commented on patch set 1 CR -1 06/11/24, 08:39

    Please add an Important RST since this is a major GUI change. Also you will likely need to update acceptance tests accordingly.
  3. core-ci voted on patch set 1 V -1 06/11/24, 08:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59134

  4. morgane garcia uploaded patch set 2 CR -1 V -1 06/11/24, 09:42

  5. core-ci voted on patch set 2 V +1 06/11/24, 09:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59149

  6. Mathias Brodala commented on patch set 3 V +1 06/11/24, 09:57

    Published edit on patch set 2.
  7. Mathias Brodala updated the commit message in patch set 4 06/11/24, 09:58

  8. Mathias Brodala commented on patch set 4 06/11/24, 09:58

    Reply

    Done
  9. core-ci voted on patch set 3 V +1 06/11/24, 10:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59157

  10. core-ci voted on patch set 4 V +1 06/11/24, 10:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59158

  11. Oliver Klee voted on patch set 4 CR +1 V +1 06/11/24, 10:36

  1. Jochen Roth voted on patch set 4 CR +1 V +1 06/11/24, 14:32

  2. Jochen Roth uploaded patch set 5 CR +1 V +1 06/11/24, 15:11

  3. Andreas Kienast commented on patch set 4 CR -1 06/11/24, 15:11

    The issue ID is not related to the patch.
  4. Jochen Roth rebased onto patch set 6 06/11/24, 15:12

  5. Andreas Kienast commented on patch set 6 CR -1 06/11/24, 15:13

    The issue ID remains wrong :)
  6. Jochen Roth updated the commit message in patch set 7 CR -1 06/11/24, 15:17

  7. Jochen Roth commented on patch set 7 06/11/24, 15:17

    Reply

    Done
  8. Andreas Kienast voted on patch set 7 CR +1 V +1 06/11/24, 15:22

  9. core-ci voted on patch set 5 V -1 06/11/24, 15:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59206

  10. core-ci voted on patch set 6 V -1 06/11/24, 15:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59208

  11. core-ci voted on patch set 7 V -1 06/11/24, 15:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59210

  12. Jochen Roth uploaded patch set 8 CR +1 V +1 06/11/24, 16:31

  13. core-ci voted on patch set 8 V +1 06/11/24, 16:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59214

  14. Oliver Klee voted on patch set 8 CR +1 V +1 06/11/24, 16:51

  15. Jasmina Ließmann voted on patch set 8 CR +1 V +1 06/11/24, 19:18

  16. Garvin Hicking commented on patch set 8 CR -1 06/11/24, 19:44

    Please don't forget an important rst that Mathias mentioned, so the docs team can sift through all of the documentation to adapt this
  17. Mathias Brodala commented on patch set 8 06/12/24, 06:57

    Reply

    There already was one, see patchset 4.
  18. Garvin Hicking commented on patch set 8 06/12/24, 07:56

    Reply

    Yes, but I don't know the reason it got removed later, so I wanted to raise attention for it
  19. Andreas Kienast commented on patch set 8 06/12/24, 07:59

    Reply

    Perhaps it was a rebase oopsie since it got lost with a rebase by @rothjochen@gmail.com.
  20. Andreas Kienast uploaded patch set 9 CR +1 V +1 06/12/24, 08:02

  21. core-ci voted on patch set 9 V +1 06/12/24, 08:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59288

  22. Oliver Klee voted on patch set 9 CR +1 V +1 06/12/24, 08:15

  23. Jasmina Ließmann commented on patch set 9 CR +1 V +1 06/12/24, 08:23

    Reply

    Done
  24. Andreas Kienast voted on patch set 9 CR +2 V +2 06/12/24, 08:31

  25. Andreas Kienast merged patch set 10 06/12/24, 08:31