Review 12.4 Abandoned

84606[TASK] Use multi record selection in SelectCheckBoxElement

Andreas Kienast CR 0 V 0 Normal +61 −126 updated 06/11/24, 17:52

Commit message

To unify and streamline record selection in the
backend does the SelectCheckBoxElement now also
utilize the MultiRecordSelection component.

This allows to get rid of the custom JS implementation.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 4

Review log 46

  1. Andreas Kienast uploaded patch set 1 06/11/24, 09:44

  2. Andreas Kienast uploaded patch set 2 06/11/24, 09:44

  3. Andreas Kienast commented on patch set 2 CR -2 06/11/24, 09:48

    Unresolved

    Waiting for a decision from @benni@typo3.org – this drops the "revert selection" button from the UI.
  4. core-ci voted on patch set 2 V +1 06/11/24, 09:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59151

  5. core-ci voted on patch set 1 V -1 06/11/24, 10:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59150

  6. Oli Bartsch abandoned the change 06/11/24, 17:52

    Won't backport this