84608[TASK] Move slug normalization into dedicated class
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Stefan Bürk +1
-
Verified V +2 Done
- Benni Mack +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 4
Review log 2337
Show 712 earlier messages
-
Rozbeh Chiryai Sharahi uploaded patch set 1 06/11/24, 09:48
-
Rozbeh Chiryai Sharahi uploaded patch set 2 06/11/24, 09:53
-
core-ci voted on patch set 1 V -1 06/11/24, 10:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59153
-
core-ci voted on patch set 2 V -1 06/11/24, 10:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59154
-
Rozbeh Chiryai Sharahi uploaded patch set 3
V -106/11/24, 10:24 -
core-ci voted on patch set 3 V +1 06/11/24, 10:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59161
-
Stefan Bürk updated the commit message in patch set 4
V +106/11/24, 13:02 -
Stefan Bürk voted on patch set 4 CR -1 06/11/24, 13:02
-
core-ci voted on patch set 4 V +1 06/11/24, 13:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59190
-
Rozbeh Chiryai Sharahi uploaded patch set 5
CR -1V +106/11/24, 14:40 -
Rozbeh Chiryai Sharahi uploaded patch set 6 06/11/24, 14:44
-
core-ci voted on patch set 5 V +1 06/11/24, 14:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59202
-
core-ci voted on patch set 6 V +1 06/11/24, 14:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59203
-
Stefan Bürk uploaded patch set 7
V +106/11/24, 20:53 -
Stefan Bürk commented on patch set 7 CR -1 06/11/24, 20:59
still on it .. -
core-ci voted on patch set 7 V +1 06/11/24, 21:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59254
-
Stefan Bürk uploaded patch set 8
CR -1V +106/12/24, 09:39 -
core-ci voted on patch set 8 V -1 06/12/24, 09:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59301
-
Stefan Bürk uploaded patch set 9
V -106/12/24, 10:12 -
core-ci voted on patch set 9 V -1 06/12/24, 10:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59307
-
Stefan Bürk uploaded patch set 10
V -106/12/24, 10:21 -
core-ci voted on patch set 10 V +1 06/12/24, 10:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59309
-
Stefan Bürk commented on patch set 10 06/12/24, 10:28
Reply
Done -
Rozbeh Chiryai Sharahi commented on patch set 10 06/12/24, 12:58
SlugNormalizer.php:40@stefan@buerk.tech I still think that this is some kind of misunderstanding. The only caller of this method is SlugHelper::sanitize which has already a null fallback to `-`. There is no need allow such a call: ``` SlugNormalizer::normalize('my string', null); ``` However, this is still possibile ``` SlugNormalizer::normalize('my string'); ``` -
Rozbeh Chiryai Sharahi updated the commit message in patch set 11
V +106/12/24, 13:00 -
Benni Mack commented on patch set 11 06/12/24, 13:04
I'm fine with this change (in general) -
core-ci voted on patch set 11 V +1 06/12/24, 13:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59326
-
Rozbeh Chiryai Sharahi commented on patch set 11 06/12/24, 13:23
SlugNormalizer.php:40ReplyIn person we discussed and stefan convinced me to stay for now with a nullable paramater. -
Rozbeh Chiryai Sharahi updated the commit message in patch set 12
V +106/13/24, 09:27 -
core-ci voted on patch set 12 V +1 06/13/24, 09:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59441
-
Stefan Bürk updated the commit message in patch set 13
V +106/13/24, 11:14 -
Stefan Bürk updated the commit message in patch set 14 06/13/24, 11:14
-
core-ci voted on patch set 14 V +1 06/13/24, 11:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59468
-
core-ci voted on patch set 13 V +1 06/13/24, 11:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59466
-
Stefan Bürk voted on patch set 14 CR +1 V +1 06/13/24, 11:47
-
Benni Mack commented on patch set 14 CR +2 V +2 06/13/24, 12:57
Thanks for adding the tests, I really enjoyed reading them! -
Benni Mack merged patch set 15 06/13/24, 12:57