Review main Merged

84610[TASK] Remove "Access for 'admin' users only!" hints in About module

Jasmina Ließmann CR +2 V +2 Easy +13 −13 updated 06/11/24, 13:09

Commit message

The "About" module lists, among other things, all backend modules
available in the system. If an admin or editor does not have access to
a module, it will not be displayed in the "About" module list.

Some of the modules listed contained a note that the module was only
accessible to administrators. With the introduction of the system
maintainer role, this note is no longer applicable. In addition, this
note was missing for some modules that cannot be made accessible to the
editor at all (e.g. "Access" module).

If an admin/system maintainer wants to check which backend modules an
editor can access, he usually switches to the backend user (via the
"Backend Users" backend module). Calling the "About" module is not
sufficient at this point, as settings in backend user groups and the
backend user accounts themselves also influence whether a backend user
can access a backend module or not.

For this reason, this note in the "About" module is now being removed.

Review

  • Code review CR +2 Done
    • Jasmina Ließmann +2
    • Georg Ringer +1
    • Michael Telgkamp +1
  • Verified V +2 Done
    • Jasmina Ließmann +2
    • Georg Ringer +1
    • Michael Telgkamp +1
    • core-ci +1 CI

Issues 1

Files 12

Review log 912

  1. Jasmina Ließmann uploaded patch set 1 06/11/24, 11:02

  2. core-ci voted on patch set 1 V +1 06/11/24, 11:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59165

  3. Jasmina Ließmann updated the commit message in patch set 2 V +1 06/11/24, 11:48

  4. core-ci voted on patch set 2 V +1 06/11/24, 11:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59173

  5. Georg Ringer commented on patch set 2 06/11/24, 11:55

    should we also backport that to v12?
  6. Jasmina Ließmann updated the commit message in patch set 3 V +1 06/11/24, 12:03

  7. Jasmina Ließmann commented on patch set 3 06/11/24, 12:04

    Reply

    OK by me. I have updated the release line accordingly.
  8. core-ci voted on patch set 3 V +1 06/11/24, 12:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59177

  9. Michael Telgkamp voted on patch set 3 CR +1 V +1 06/11/24, 12:12

  10. Georg Ringer voted on patch set 3 CR +1 V +1 06/11/24, 12:52

  11. Jasmina Ließmann voted on patch set 3 CR +2 V +2 06/11/24, 13:00

  12. Jasmina Ließmann merged patch set 4 06/11/24, 13:09