Review main Merged

84611[FEATURE] Option to report redirects in link validator

Christian Weiske CR +2 V +2 Normal +56 −1 updated 01/24/25, 10:26

Commit message

This patch adds the new configuration option
`mod.linkvalidator.linktypesConfig.external.allowRedirects`
(defaults to true).

When redirects are disallowed, external links that give responses
with HTTP status codes 301, 302, 303 and 307
are reported as errors by the link checker.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1930

Show 35 earlier messages
  1. Christian Weiske uploaded patch set 1 06/11/24, 11:24

  2. core-ci voted on patch set 1 V +1 06/11/24, 11:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59168

  3. Christian Weiske uploaded patch set 2 V +1 06/11/24, 11:31

  4. core-ci voted on patch set 2 V +1 06/11/24, 11:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59171

  5. Georg Ringer commented on patch set 2 06/11/24, 21:17

    Feature-104047-AllowRedirectsLinkValidator.rst:16

    please state that this is about redirects of guzzle to check external links. I had a hard time because I thought about ext:redirects which is of course wrong.
  1. Christian Weiske uploaded patch set 3 V +1 06/12/24, 06:01

  2. Christian Weiske commented on patch set 3 06/12/24, 06:01

    Feature-104047-AllowRedirectsLinkValidator.rst:16 Reply

    Done
  3. core-ci voted on patch set 3 V +1 06/12/24, 06:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59277

  4. Benni Mack updated the commit message in patch set 4 V +1 08/06/24, 12:35

  5. Benni Mack commented on patch set 5 08/06/24, 12:35

    Published edit on patch set 4.
  6. core-ci voted on patch set 4 V -1 08/06/24, 12:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62926

  7. core-ci voted on patch set 5 V -1 08/06/24, 12:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62927

  8. Benni Mack rebased onto patch set 6 V -1 08/06/24, 12:45

  9. Stefan Bürk commented on patch set 6 08/06/24, 12:50

    ExternalLinktype.php:279

    308 is similar to 301, except it would prohibit POST to GET redirect. Literally, it would be wrong for a GET request, but who knows. I'd say we should either add 308 in the pot with 301 (or having a dedicated one). At least that would be consequent to 302<->307
  10. core-ci voted on patch set 6 V -1 08/06/24, 12:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62930

  11. core-ci commented on patch set 6 08/06/24, 13:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62930

  12. core-ci commented on patch set 6 08/06/24, 13:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62930

  13. Benni Mack uploaded patch set 7 V -1 01/22/25, 09:27

  14. Benni Mack commented on patch set 7 CR +1 01/22/25, 09:28

    ExternalLinktype.php:279 Reply

    Done
  15. core-ci voted on patch set 7 V +1 01/22/25, 09:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72831

  16. Benni Mack commented on patch set 8 CR +1 V +1 01/22/25, 11:53

    Published edit on patch set 7.
  17. core-ci voted on patch set 8 V +1 01/22/25, 12:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72848

  18. Stefan Bürk voted on patch set 8 CR +1 V +1 01/22/25, 13:57

  19. Andreas Kienast voted on patch set 8 CR +1 01/22/25, 14:50

  20. Benni Mack uploaded patch set 9 CR +1 V +1 01/22/25, 15:54

  21. Benni Mack voted on patch set 9 CR +1 01/22/25, 15:54

  22. core-ci voted on patch set 9 V +1 01/22/25, 16:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72869

  23. Stefan Bürk voted on patch set 9 CR +1 V +1 01/24/25, 10:20

  24. Benni Mack voted on patch set 9 CR +2 V +2 01/24/25, 10:26

  25. Benni Mack merged patch set 10 01/24/25, 10:26