84614[BUGFIX] Correct heading hierarchy in various backend modals
Commit message
Review
-
Code review CR +2 Done
- Jasmina Ließmann +2
- Benni Mack +1
-
Verified V +2 Done
- Jasmina Ließmann +2
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 20
- Build/Sources/TypeScript/backend/modal.ts+1 −1
- Build/Sources/TypeScript/form/backend/form-manager/view-model.ts+2 −2
- Build/Sources/TypeScript/install/renderable/language-packs.ts+2 −2
- typo3/sysext/backend/Resources/Public/JavaScript/modal.js+1 −1
- typo3/sysext/core/Tests/Acceptance/Application/InstallTool/MaintenanceCest.php3+6 −6
- typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Modals/InsertElements.html+2 −2
- typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Modals/InsertPages.html+2 −2
- typo3/sysext/form/Resources/Public/JavaScript/backend/form-manager/view-model.js+1 −1
- typo3/sysext/install/Resources/Private/Partials/Settings/ExtensionConfiguration/ExtensionForm.html+2 −2
- typo3/sysext/install/Resources/Private/Partials/Settings/LocalConfiguration/SubSection.html+2 −2
- typo3/sysext/install/Resources/Private/Partials/Settings/Presets/Cache.html+2 −2
- typo3/sysext/install/Resources/Private/Partials/Settings/Presets/Context.html+2 −2
- typo3/sysext/install/Resources/Private/Partials/Settings/Presets/Image.html+2 −2
- typo3/sysext/install/Resources/Private/Partials/Settings/Presets/Mail.html+2 −2
- typo3/sysext/install/Resources/Private/Partials/Settings/Presets/PasswordHashing.html+2 −2
- typo3/sysext/install/Resources/Private/Partials/Upgrade/UpgradeDocs/PanelItem.html+2 −2
- typo3/sysext/install/Resources/Private/Templates/Environment/ImageProcessing.html+8 −8
- typo3/sysext/install/Resources/Private/Templates/Settings/FeaturesGetContent.html+2 −5
- typo3/sysext/install/Resources/Private/Templates/Upgrade/ExtensionScanner.html+4 −4
- typo3/sysext/install/Resources/Public/JavaScript/renderable/language-packs.js+2 −2
Review log 3455
Show 1830 earlier messages
-
Christian Rath-Ulrich uploaded patch set 1 06/11/24, 12:25
-
core-ci voted on patch set 1 V -1 06/11/24, 12:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59183
-
Christian Rath-Ulrich rebased onto patch set 2
V -106/11/24, 13:18 -
core-ci voted on patch set 2 V -1 06/11/24, 13:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59192
-
Andreas Kienast commented on patch set 2 06/11/24, 13:36
Please note you have to build the TypeScript sources and commit the result as well. -
Christian Rath-Ulrich uploaded patch set 3
V -106/11/24, 13:48 -
Christian Rath-Ulrich commented on patch set 3 06/11/24, 13:49
Reply
yes thx done that now -
core-ci voted on patch set 3 V -1 06/11/24, 13:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59196
-
Christian Rath-Ulrich uploaded patch set 4
V -106/11/24, 14:23 -
core-ci voted on patch set 4 V -1 06/11/24, 14:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59199
-
Christian Rath-Ulrich uploaded patch set 5
V -106/11/24, 16:25 -
core-ci voted on patch set 5 V -1 06/11/24, 16:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59212
-
Christian Rath-Ulrich uploaded patch set 6
V -106/11/24, 16:38 -
core-ci voted on patch set 6 V +1 06/11/24, 16:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59215
-
Jasmina Ließmann commented on patch set 6 06/11/24, 17:20
MaintenanceCest.php:44Should we really remove the heading identifier in this file? What about replacing h4 with h1? -
Christian Rath-Ulrich commented on patch set 6 06/11/24, 17:25
MaintenanceCest.php:44ReplyStrangely enough, the h4 was never on the modal-dialog, but on the modal-title. I didn't want to rewrite the entire test. -
Christian Rath-Ulrich uploaded patch set 7
V +106/11/24, 17:48 -
Christian Rath-Ulrich commented on patch set 7 06/11/24, 17:55
MaintenanceCest.php:44ReplyDone -
Christian Rath-Ulrich updated the commit message in patch set 8 06/11/24, 17:56
-
core-ci voted on patch set 7 V -1 06/11/24, 17:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59225
-
Jasmina Ließmann uploaded patch set 9 06/11/24, 17:59
-
core-ci voted on patch set 8 V -1 06/11/24, 18:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59228
-
core-ci voted on patch set 9 V -1 06/11/24, 18:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59229
-
Jasmina Ließmann uploaded patch set 10
V -106/11/24, 18:10 -
core-ci voted on patch set 10 V +1 06/11/24, 18:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59232
-
Jasmina Ließmann updated the commit message in patch set 11
V +106/11/24, 18:21 -
Christian Rath-Ulrich updated the commit message in patch set 12 06/11/24, 18:21
-
core-ci voted on patch set 11 V +1 06/11/24, 18:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59233
-
core-ci voted on patch set 12 V +1 06/11/24, 18:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59234
-
Christian Rath-Ulrich uploaded patch set 13
V +106/11/24, 18:30
-
core-ci voted on patch set 13 V -1 06/11/24, 18:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59235
-
Christian Rath-Ulrich uploaded patch set 14
V -106/11/24, 19:08 -
core-ci voted on patch set 14 V +1 06/11/24, 19:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59240
-
Christian Rath-Ulrich uploaded patch set 15
V +106/11/24, 19:20 -
core-ci voted on patch set 15 V +1 06/11/24, 19:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59242
-
Jasmina Ließmann uploaded patch set 16
V +106/13/24, 09:19 -
Jasmina Ließmann uploaded patch set 17 06/13/24, 09:20
-
Jasmina Ließmann uploaded patch set 18 06/13/24, 09:23
-
core-ci voted on patch set 17 V +1 06/13/24, 09:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59439
-
core-ci voted on patch set 16 V +1 06/13/24, 09:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59438
-
core-ci voted on patch set 18 V +1 06/13/24, 09:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59440
-
Jasmina Ließmann voted on patch set 18 CR +1 V +1 06/13/24, 09:47
-
Jasmina Ließmann uploaded patch set 19
CR +1V +108/06/24, 12:21 -
core-ci voted on patch set 19 V -1 08/06/24, 12:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62923
-
core-ci voted on patch set 19 V +1 08/06/24, 12:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62923
-
Jasmina Ließmann voted on patch set 19 CR +1 V +1 08/06/24, 12:47
-
Benni Mack updated the commit message in patch set 20
CR +1V +110/18/24, 13:42 -
Oli Bartsch abandoned the change 12/18/24, 11:08
I'm abandoning this since there's been no activity on this for several months. If you'd like to pick it up again in the future, feel free to restore it anytime. Thanks! -
Jasmina Ließmann restored the change 12/18/24, 17:33
-
Jasmina Ließmann uploaded patch set 21 12/18/24, 18:08
-
core-ci voted on patch set 21 V +1 12/18/24, 18:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71403
-
Jasmina Ließmann voted on patch set 21 CR +1 V +1 12/18/24, 18:17
-
Benni Mack voted on patch set 21 CR +1 V +1 12/18/24, 20:55
-
Jasmina Ließmann voted on patch set 21 CR +2 V +2 12/18/24, 20:58
-
Jasmina Ließmann merged patch set 22 12/18/24, 21:07