Review main Merged

84614[BUGFIX] Correct heading hierarchy in various backend modals

Christian Rath-Ulrich CR +2 V +2 Normal +49 −52 updated 12/18/24, 21:07

Commit message

Review

  • Code review CR +2 Done
    • Jasmina Ließmann +2
    • Benni Mack +1
  • Verified V +2 Done
    • Jasmina Ließmann +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 20

Review log 3455

Show 1830 earlier messages
  1. Christian Rath-Ulrich uploaded patch set 1 06/11/24, 12:25

  2. core-ci voted on patch set 1 V -1 06/11/24, 12:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59183

  3. Christian Rath-Ulrich rebased onto patch set 2 V -1 06/11/24, 13:18

  4. core-ci voted on patch set 2 V -1 06/11/24, 13:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59192

  5. Andreas Kienast commented on patch set 2 06/11/24, 13:36

    Please note you have to build the TypeScript sources and commit the result as well.
  6. Christian Rath-Ulrich uploaded patch set 3 V -1 06/11/24, 13:48

  7. Christian Rath-Ulrich commented on patch set 3 06/11/24, 13:49

    Reply

    yes thx done that now
  8. core-ci voted on patch set 3 V -1 06/11/24, 13:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59196

  9. Christian Rath-Ulrich uploaded patch set 4 V -1 06/11/24, 14:23

  10. core-ci voted on patch set 4 V -1 06/11/24, 14:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59199

  11. Christian Rath-Ulrich uploaded patch set 5 V -1 06/11/24, 16:25

  12. core-ci voted on patch set 5 V -1 06/11/24, 16:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59212

  13. Christian Rath-Ulrich uploaded patch set 6 V -1 06/11/24, 16:38

  14. core-ci voted on patch set 6 V +1 06/11/24, 16:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59215

  15. Jasmina Ließmann commented on patch set 6 06/11/24, 17:20

    MaintenanceCest.php:44

    Should we really remove the heading identifier in this file? What about replacing h4 with h1?
  16. Christian Rath-Ulrich commented on patch set 6 06/11/24, 17:25

    MaintenanceCest.php:44 Reply

    Strangely enough, the h4 was never on the modal-dialog, but on the modal-title. I didn't want to rewrite the entire test.
  17. Christian Rath-Ulrich uploaded patch set 7 V +1 06/11/24, 17:48

  18. Christian Rath-Ulrich commented on patch set 7 06/11/24, 17:55

    MaintenanceCest.php:44 Reply

    Done
  19. Christian Rath-Ulrich updated the commit message in patch set 8 06/11/24, 17:56

  20. core-ci voted on patch set 7 V -1 06/11/24, 17:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59225

  21. Jasmina Ließmann uploaded patch set 9 06/11/24, 17:59

  22. core-ci voted on patch set 8 V -1 06/11/24, 18:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59228

  23. core-ci voted on patch set 9 V -1 06/11/24, 18:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59229

  24. Jasmina Ließmann uploaded patch set 10 V -1 06/11/24, 18:10

  25. core-ci voted on patch set 10 V +1 06/11/24, 18:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59232

  26. Jasmina Ließmann updated the commit message in patch set 11 V +1 06/11/24, 18:21

  27. Christian Rath-Ulrich updated the commit message in patch set 12 06/11/24, 18:21

  28. core-ci voted on patch set 11 V +1 06/11/24, 18:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59233

  29. core-ci voted on patch set 12 V +1 06/11/24, 18:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59234

  30. Christian Rath-Ulrich uploaded patch set 13 V +1 06/11/24, 18:30

  1. core-ci voted on patch set 13 V -1 06/11/24, 18:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59235

  2. Christian Rath-Ulrich uploaded patch set 14 V -1 06/11/24, 19:08

  3. core-ci voted on patch set 14 V +1 06/11/24, 19:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59240

  4. Christian Rath-Ulrich uploaded patch set 15 V +1 06/11/24, 19:20

  5. core-ci voted on patch set 15 V +1 06/11/24, 19:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59242

  6. Jasmina Ließmann uploaded patch set 16 V +1 06/13/24, 09:19

  7. Jasmina Ließmann uploaded patch set 17 06/13/24, 09:20

  8. Jasmina Ließmann uploaded patch set 18 06/13/24, 09:23

  9. core-ci voted on patch set 17 V +1 06/13/24, 09:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59439

  10. core-ci voted on patch set 16 V +1 06/13/24, 09:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59438

  11. core-ci voted on patch set 18 V +1 06/13/24, 09:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59440

  12. Jasmina Ließmann voted on patch set 18 CR +1 V +1 06/13/24, 09:47

  13. Jasmina Ließmann uploaded patch set 19 CR +1 V +1 08/06/24, 12:21

  14. core-ci voted on patch set 19 V -1 08/06/24, 12:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62923

  15. core-ci voted on patch set 19 V +1 08/06/24, 12:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62923

  16. Jasmina Ließmann voted on patch set 19 CR +1 V +1 08/06/24, 12:47

  17. Benni Mack updated the commit message in patch set 20 CR +1 V +1 10/18/24, 13:42

  18. Oli Bartsch abandoned the change 12/18/24, 11:08

    I'm abandoning this since there's been no activity on this for several months. If you'd like to pick it up again in the future, feel free to restore it anytime. Thanks!
  19. Jasmina Ließmann restored the change 12/18/24, 17:33

  20. Jasmina Ließmann uploaded patch set 21 12/18/24, 18:08

  21. core-ci voted on patch set 21 V +1 12/18/24, 18:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71403

  22. Jasmina Ließmann voted on patch set 21 CR +1 V +1 12/18/24, 18:17

  23. Benni Mack voted on patch set 21 CR +1 V +1 12/18/24, 20:55

  24. Jasmina Ließmann voted on patch set 21 CR +2 V +2 12/18/24, 20:58

  25. Jasmina Ließmann merged patch set 22 12/18/24, 21:07