Review main Merged

84618[DOCS] Adapt EXT:seo documentation for current terminology

Garvin Hicking CR +2 V +2 Normal +127 −114 updated 07/12/24, 12:10

Commit message

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 4

Review log 1519

  1. Garvin Hicking uploaded patch set 1 06/11/24, 14:52

  2. Garvin Hicking commented on patch set 1 06/11/24, 14:54

    Added some of the docs team for review. Please feel free to directly push patches. I cannot offer to update screenshots; if no one volunteers this needs to be part of a follow-up patch.
  3. core-ci voted on patch set 1 V +1 06/11/24, 14:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59204

  4. Chris Müller commented on patch set 1 06/13/24, 13:21

    Index.rst:26

    The "From version 9 of TYPO3" can be omitted nowadays.

    Index.rst:60

    "... make sure your Locale other language fields ..." sounds strange.

    Index.rst:105

    "to use at least" instead "to at least use"
  5. Garvin Hicking uploaded patch set 2 V +1 06/14/24, 06:32

    Address code review
  6. Garvin Hicking commented on patch set 2 06/14/24, 06:33

    Thanks Chris, applied all your suggestions. Also globally changed "best practise" to "best practice" because in both UK and US english this was wrong :)

    Index.rst:26 Reply

    Done

    Index.rst:60 Reply

    Done

    Index.rst:105 Reply

    Done
  7. core-ci voted on patch set 2 V +1 06/14/24, 06:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59569

  8. Garvin Hicking uploaded patch set 3 V +1 07/12/24, 08:44

    resolve conflict
  9. Lina Wolf voted on patch set 3 CR +1 V +1 07/12/24, 08:45

  10. core-ci voted on patch set 3 V +1 07/12/24, 08:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61466

  11. Christian Kuhn voted on patch set 3 CR +2 V +2 07/12/24, 09:57

  12. Stefan Froemken commented on patch set 3 07/12/24, 10:04

    Index.rst:37

    Two missing "="
  13. Christian Kuhn commented on patch set 3 CR +1 07/12/24, 11:09

    garvin will re-push. i will then merge main and v12.
  14. Garvin Hicking uploaded patch set 4 CR +1 V +1 07/12/24, 11:15

  15. Garvin Hicking commented on patch set 4 07/12/24, 11:15

    Index.rst:37 Reply

    Done
  16. core-ci voted on patch set 4 V +1 07/12/24, 11:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61477

  17. Christian Kuhn voted on patch set 4 CR +2 V +2 07/12/24, 12:06

  18. Christian Kuhn commented on patch set 4 07/12/24, 12:10

    will merge: latest patch set only changed a formatting details, previous votes still apply.
  19. Christian Kuhn merged patch set 5 07/12/24, 12:10