Review main Merged

84619[TASK] Group database analyzer errors

Jochen Roth CR +2 V +2 Easy +37 −2 updated 09/19/24, 22:20

Commit message

Currently, database analyzer errors are
displayed as notifications in the bottom
right corner. If >10 errors its kinda
hard to digest for a user.

This has been changed, to display
the notifications within the modal
and group all errors in a single
notification using a unordered list.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1931

Show 46 earlier messages
  1. Jochen Roth uploaded patch set 1 06/11/24, 15:11

  2. Jochen Roth rebased onto patch set 2 06/11/24, 15:14

  3. core-ci voted on patch set 1 V -1 06/11/24, 15:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59207

  4. core-ci voted on patch set 2 V +1 06/11/24, 15:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59209

  5. Jochen Roth uploaded patch set 3 V +1 09/09/24, 15:01

  6. Jochen Roth uploaded patch set 4 09/09/24, 15:06

  1. core-ci voted on patch set 3 V -1 09/09/24, 15:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65105

  2. core-ci voted on patch set 4 V -1 09/09/24, 15:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65106

  3. Andreas Kienast commented on patch set 4 CR -1 09/09/24, 15:26

    database-analyzer.ts:85

    Please call this before `.analyze()`.

    database-analyzer.ts:91

    Please call this before `.execute()`.

    database-analyzer.ts:258

    `.replaceChildren()`
  4. Andreas Kienast commented on patch set 4 09/09/24, 15:27

    DatabaseAnalyzer.html:9

    Why is this a paragraph?
  5. Jochen Roth uploaded patch set 5 CR -1 V -1 09/09/24, 15:30

  6. core-ci voted on patch set 5 V +1 09/09/24, 15:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65109

  7. Jochen Roth uploaded patch set 6 V +1 09/09/24, 15:49

  8. Jochen Roth uploaded patch set 7 09/09/24, 15:50

  9. Jochen Roth commented on patch set 7 09/09/24, 15:53

    database-analyzer.ts:85 Reply

    Done

    database-analyzer.ts:91 Reply

    Done

    database-analyzer.ts:258 Reply

    Done

    DatabaseAnalyzer.html:9 Reply

    Done
  10. core-ci voted on patch set 6 V -1 09/09/24, 16:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65112

  11. core-ci voted on patch set 7 V -1 09/09/24, 16:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65114

  12. core-ci voted on patch set 7 V +1 09/09/24, 16:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65114

  13. Frank Nägler commented on patch set 7 CR -1 V +1 09/10/24, 17:00

    database-analyzer.ts:224

    Can you please add SecurityUtility.encodeHtml ?
  14. Jochen Roth uploaded patch set 8 CR -1 V +1 09/10/24, 20:28

  15. Jochen Roth commented on patch set 8 09/10/24, 20:35

    database-analyzer.ts:224 Reply

    Done
  16. core-ci voted on patch set 8 V -1 09/10/24, 20:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65346

  17. core-ci voted on patch set 8 V +1 09/11/24, 07:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65346

  18. Oli Bartsch commented on patch set 8 V -1 09/12/24, 15:47

    database-analyzer.ts:232

    This should not be done in case `groupedErrors` is empty.
  19. Jochen Roth uploaded patch set 9 V +1 09/12/24, 16:59

  20. Jochen Roth uploaded patch set 10 09/12/24, 17:02

  21. core-ci voted on patch set 9 V -1 09/12/24, 17:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65594

  22. core-ci voted on patch set 10 V +1 09/12/24, 17:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65595

  23. Oli Bartsch voted on patch set 10 CR +1 V +1 09/12/24, 17:14

  24. Christian Kuhn commented on patch set 10 CR +2 V +2 09/19/24, 22:20

    database-analyzer.ts:232 Reply

    Done
  25. Christian Kuhn merged patch set 11 09/19/24, 22:20