Review 12.4 Merged

84628[BUGFIX] Handle state for "revert selection" correctly

Oli Bartsch CR +2 V +2 Easy +22 −5 updated 06/12/24, 09:31

Commit message

The "revert selection" action of the
SelectCheckBoxElement does now properly
handle the current element's "checked"
state. This way, the action button gets
visible once the initial state is changed
(by checking / unchecking checkboxes) and
is disabled again, in case the initial state
gets restored.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jasmina Ließmann +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jasmina Ließmann +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 710

  1. Oli Bartsch uploaded patch set 1 06/11/24, 19:54

  2. core-ci voted on patch set 1 V +1 06/11/24, 20:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59248

  3. Oli Bartsch uploaded patch set 2 V +1 06/12/24, 07:21

  4. core-ci voted on patch set 2 V +1 06/12/24, 07:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59281

  5. Andreas Kienast uploaded patch set 3 V +1 06/12/24, 07:27

  6. Andreas Kienast voted on patch set 3 CR +1 V +1 06/12/24, 07:27

  7. core-ci voted on patch set 3 V +1 06/12/24, 07:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59282

  8. Jasmina Ließmann voted on patch set 3 CR +1 V +1 06/12/24, 08:07

  9. Oli Bartsch voted on patch set 3 CR +2 V +2 06/12/24, 09:31

  10. Oli Bartsch merged patch set 4 06/12/24, 09:31