84629[BUGFIX] Fix pid constraint for suggestOptions
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Garvin Hicking +1
- Guido Schmechel +1
- Benni Mack +1
-
Verified V +2 Done
- Georg Ringer +2
- Garvin Hicking +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1012
-
Georg Ringer uploaded patch set 1 06/11/24, 20:37
-
Georg Ringer commented on patch set 1 06/11/24, 20:37
This change is ready for review. -
core-ci voted on patch set 1 V +1 06/11/24, 20:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59250
-
Garvin Hicking commented on patch set 1 CR +1 06/12/24, 16:12
I can confirm that the code would need this adoption. However, I cannot reproduce this with EXT:styleguide in the mentioned fields? The styleguide also does not seem to provide any flexform with a "pidList", so I think we should add that to the mix?! -
Benni Mack commented on patch set 1 CR -1 06/21/24, 10:28
We need tests for this, I can see if I can create some (this class does not have any tests yet, and adding a simple functional test should be easy) -
Benni Mack uploaded patch set 2
CR +1V +107/15/24, 12:10 -
Benni Mack commented on patch set 2 CR +1 V +1 07/15/24, 12:11
Tests made it pretty easy that using "pidList" will fail completely without this change. -
core-ci voted on patch set 2 V +1 07/15/24, 12:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61579
-
Garvin Hicking voted on patch set 2 CR +1 V +1 07/15/24, 12:49
-
Guido Schmechel voted on patch set 2 CR +1 07/15/24, 13:36
-
Georg Ringer voted on patch set 2 CR +2 V +2 07/15/24, 13:40
-
Georg Ringer merged patch set 3 07/15/24, 13:40