Review main Merged

84629[BUGFIX] Fix pid constraint for suggestOptions

Georg Ringer CR +2 V +2 Easy +48 −1 updated 07/15/24, 13:40

Commit message

Remove the spread operator when merging page ids for generating
a constraint on the pids in the suggestOptions.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Garvin Hicking +1
    • Guido Schmechel +1
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Garvin Hicking +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1012

  1. Georg Ringer uploaded patch set 1 06/11/24, 20:37

  2. Georg Ringer commented on patch set 1 06/11/24, 20:37

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 06/11/24, 20:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59250

  4. Garvin Hicking commented on patch set 1 CR +1 06/12/24, 16:12

    I can confirm that the code would need this adoption. However, I cannot reproduce this with EXT:styleguide in the mentioned fields? The styleguide also does not seem to provide any flexform with a "pidList", so I think we should add that to the mix?!
  5. Benni Mack commented on patch set 1 CR -1 06/21/24, 10:28

    We need tests for this, I can see if I can create some (this class does not have any tests yet, and adding a simple functional test should be easy)
  6. Benni Mack uploaded patch set 2 CR +1 V +1 07/15/24, 12:10

  7. Benni Mack commented on patch set 2 CR +1 V +1 07/15/24, 12:11

    Tests made it pretty easy that using "pidList" will fail completely without this change.
  8. core-ci voted on patch set 2 V +1 07/15/24, 12:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61579

  9. Garvin Hicking voted on patch set 2 CR +1 V +1 07/15/24, 12:49

  10. Guido Schmechel voted on patch set 2 CR +1 07/15/24, 13:36

  11. Georg Ringer voted on patch set 2 CR +2 V +2 07/15/24, 13:40

  12. Georg Ringer merged patch set 3 07/15/24, 13:40