Review main Merged

84630[TASK] Make slug fields TEXT by default

Christian Kuhn CR +2 V +2 Easy +4 −4 updated 07/09/24, 15:51

Commit message

Big VARCHAR fields can be problematic with mysql/mariadb [1],
as outlined in [2]: A utf8mb4 varchar(2048) eats 8096 table
size space.
We can mitigate by making type="slug" fields a TEXT field
instead, which saves quite a bit of precious row size
especially in the pages table.

[1] https://mariadb.com/kb/en/innodb-row-formats-overview/#maximum-row-size
[2] https://github.com/contao/contao/issues/4159

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Garvin Hicking +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Garvin Hicking +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 3

Files 2

Review log 910

  1. Christian Kuhn uploaded patch set 1 06/11/24, 20:45

  2. Tymoteusz Motylewski commented on patch set 1 06/11/24, 20:48

    curious, why slug has to be utf8mb4? i dont expect emoji in there. shouldnt slugs be always transliterated to ascii?
  3. core-ci voted on patch set 1 V +1 06/11/24, 20:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59251

  4. Stefan Bürk voted on patch set 1 CR +1 V +1 06/11/24, 20:55

  5. Garvin Hicking voted on patch set 1 CR +1 V +1 06/11/24, 21:16

  6. Georg Ringer voted on patch set 1 CR +2 V +2 06/11/24, 23:08

  7. Georg Ringer merged patch set 2 06/11/24, 23:08

  8. Andreas Kienast commented on patch set 2 06/12/24, 06:29

    Post -1: "Releases" line is missing
  9. Tymoteusz Motylewski commented on patch set 2 06/12/24, 06:31

    Reply

    does using row format „Dynamic” solve the issue?
  10. Stefan Bürk commented on patch set 2 06/12/24, 06:57

    Reply

    Would shift the issue only a bit, but not solving it completly. We do not have the ability to define a) a dedicated charset/collation for a column (parser, compare, db structure read) and b) define the row format. Scheduled to worked on but not doable with a quick shot.