Review 12.4 Merged

84649[TASK] Revert "Prevent requiring "typo3conf" for Composer mode in Dir. Status"

Helmut Hummel CR +2 V +2 Normal +33 −40 updated 06/17/24, 12:56

Commit message

This reverts commit 4b89b371d0f013b365bdffe7eec24689db9896f4.

Reason for revert: The typo3conf folder is still used
by the backend:lock and backend:unlock cli commands
and the corresponding backend locking functionality

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 911

  1. Helmut Hummel uploaded patch set 1 06/15/24, 19:41

  2. core-ci voted on patch set 1 V +1 06/15/24, 19:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59652

  3. Benni Mack updated the commit message in patch set 2 V +1 06/15/24, 20:51

  4. Benni Mack voted on patch set 2 CR +1 V +1 06/15/24, 20:51

  5. core-ci voted on patch set 2 V +1 06/15/24, 20:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59655

  6. Garvin Hicking commented on patch set 2 06/15/24, 23:47

    Sorry that this caused problems. Thanks for raising attention. Could we adjust backend:(un)lock to use other dirs in composer mode? (couldn't check) We might also need to adjust docs and migration guide which often refer to typo3conf as droppable which wouldn't be the case then? Maybe also add a code comment to this place to notify about this fact for future-selves, if it can't be changed?
  7. Georg Ringer commented on patch set 2 06/16/24, 18:31

    Reply

    i would do it just as ENABLE_INSTALL_TOOL - there is a new path and also the fallback still checked
  8. Benni Mack commented on patch set 2 06/17/24, 06:46

    Reply

    Hey Garvin, don't worry that much about it. That's the regular procedure: We do a revert, and then improve the previous behavior.
  9. Garvin Hicking commented on patch set 2 CR +1 V +1 06/17/24, 08:54

    Reply

    Ack. I think moving LOCK_BACKEND to /var/transient (like ENABLE_INSTALL_TOOL) should work out. Will create a new patch with that.
  10. Christian Kuhn voted on patch set 2 CR +2 V +2 06/17/24, 12:50

  11. Christian Kuhn merged patch set 3 06/17/24, 12:56