Review main Merged

84652[FEATURE] Add CLI command `install:password:set`

Rozbeh Chiryai Sharahi CR +2 V +2 Hard +379 −0 updated 07/04/25, 09:18

Commit message

A new command is introduced to set a new Install Tool password:

```
bin/typo3 install:password:set --dry-run --no-interaction
```

This allows for more automation and offers the ability to use the CLI
for resetting an instance's password without the need to manually
hash passwords.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Benjamin Franzke +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Benjamin Franzke +1
    • core-ci +1 CI

Issues 2

Files 5

Review log 85113

Show 6588 earlier messages
  1. Rozbeh Chiryai Sharahi uploaded patch set 1 06/11/24, 21:37

  2. core-ci voted on patch set 1 V -1 06/11/24, 21:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59255

  3. Rozbeh Chiryai Sharahi uploaded patch set 2 V -1 06/11/24, 21:49

  4. core-ci voted on patch set 2 V +1 06/11/24, 21:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59256

  5. Stefan Bürk commented on patch set 2 06/12/24, 06:59

    Would be nice to have a option which returns only the generated password, plain or as json so it can be used easily in scripts (for deployment processes / pipelines etc) - a.k.a. easy machine parsable.
  6. Rozbeh Chiryai Sharahi uploaded patch set 3 V +1 06/12/24, 08:52

  7. Rozbeh Chiryai Sharahi commented on patch set 3 06/12/24, 08:54

    Reply

    Good idea. Will do that
  8. core-ci voted on patch set 3 V -1 06/12/24, 08:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59289

  9. Rozbeh Chiryai Sharahi uploaded patch set 4 V -1 06/12/24, 12:11

  10. core-ci voted on patch set 4 V -1 06/12/24, 12:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59319

  11. Rozbeh Chiryai Sharahi uploaded patch set 5 V -1 06/12/24, 12:23

  12. core-ci voted on patch set 5 V -1 06/12/24, 12:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59320

  13. Rozbeh Chiryai Sharahi uploaded patch set 6 V -1 06/12/24, 12:32

  14. core-ci voted on patch set 6 V +1 06/12/24, 12:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59323

  15. Rozbeh Chiryai Sharahi commented on patch set 6 06/12/24, 12:45

    Reply

    As we have discussed in person: The commands scope is to update the install-tool-password and not to generate any kind of hashed-password. I renamed it to `install:password:set` and introduced the possibility for a dry option in case someone wants to manually add the password to his settings.php for some reason. Could you resolve this thread?
  16. Garvin Hicking commented on patch set 6 06/12/24, 13:17

    What a great thing! Love the idea and your work on it, thanks! Would you like to add an accompanying feature RST file documenting the usage? Let me know if I can help with that.
  17. Rozbeh Chiryai Sharahi updated the commit message in patch set 7 V +1 06/12/24, 13:31

  18. core-ci voted on patch set 7 V +1 06/12/24, 13:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59330

  19. Garvin Hicking commented on patch set 7 06/12/24, 13:57

    Some more comments, hope they help.

    PasswordSetCommand.php:62

    This code comment refers to another file I think, would need a unique description

    PasswordSetCommand.php:79

    This could maybe earn an extra check for actual stringlength or stringiness? Currently I can pass "--password=0" and would be asked for a password.

    PasswordSetCommand.php:102

    This seems to be unique in the core, but refers to a pretty old timestamp - did you copy this from somewhere maybe where the exception could would then create a dupe? To be sure, please use a current timestamp 😊

    RuntimeException.php:20

    Maybe use a unique name for this? Most other core extended RuntimeExceptions have a unique name to better indicate what they refer to, so in thise case somehting like a "ConsoleHelperNotFoundException" or something like that?
  20. Rozbeh Chiryai Sharahi commented on patch set 7 06/12/24, 14:21

    PasswordSetCommand.php:62 Reply

    Wow thanks for the review. Regarding the other points: Will address that all, give me a sec. Regarding exception number: I did not even know that we are always using the timestamp 😄 I simply added a random number and hoped it is not used.
  21. Rozbeh Chiryai Sharahi uploaded patch set 8 V +1 06/12/24, 14:39

  22. Rozbeh Chiryai Sharahi commented on patch set 8 06/12/24, 14:40

    Reply

    I addressed all your comments. Could you set them to resolved in case they were addressed correctly to your opinion?
  23. core-ci voted on patch set 8 V +1 06/12/24, 14:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59339

  24. Rozbeh Chiryai Sharahi commented on patch set 8 06/12/24, 14:49

    Reply

    Yes, i will add a documentation, for sure.
  25. Garvin Hicking commented on patch set 8 06/12/24, 14:52

    Thanks for addressing this so quick and your feedback. One issue is left for me about "--password" or "--password=0". Maybe if you review this with Stefan later he has valuable feedback on this. :-) Great work!

    PasswordSetCommand.php:62 Reply

    Done

    PasswordSetCommand.php:79 Reply

    I think this still has an issue. If I call with "--password=" it says "Password hashed: " (empty). I think in this case the auto-creation does need to kick in. Personally I would do a `if ((string)$password === '')`...?

    PasswordSetCommand.php:102 Reply

    Done

    RuntimeException.php:20 Reply

    Done
  26. Rozbeh Chiryai Sharahi uploaded patch set 9 V +1 06/12/24, 15:28

  27. core-ci voted on patch set 9 V -1 06/12/24, 15:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59340

  28. Garvin Hicking commented on patch set 9 06/12/24, 15:40

    Feature-103956-IntroduceInstallpasswordsetCommand.rst:6

    I think you either need to use "Resolves: 103956" here, or the RST would need to reference feature 104058 instead. Also check out your commit message it says "Releases: 13" but "13" currently is main. So "Releases: main" would be sufficient.

    Feature-103956-IntroduceInstallpasswordsetCommand.rst:38

    What would this do, forcibly create a random password? In this case maybe write: "No interaction mode (auto-generated password)" ?

    Feature-103956-IntroduceInstallpasswordsetCommand.rst:47

    We usually write something like "The Install Tool password can now also be set via CLI instead of only via direct file access, allowing for more automation and easy hash generation without extra steps"...?

    PasswordSetCommand.php:99

    I think trim() makes a problem here. If I enter " " as a password it would actually be accepted as such and hashed...? Sorry if I am making this cumbersome, but I'd rather be very specific here than to create edge-cases :-)
  29. Rozbeh Chiryai Sharahi uploaded patch set 10 V -1 06/12/24, 15:46

  30. Rozbeh Chiryai Sharahi uploaded patch set 11 06/12/24, 15:46

  31. core-ci voted on patch set 10 V +1 06/12/24, 15:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59342

  32. Rozbeh Chiryai Sharahi commented on patch set 11 06/12/24, 15:52

    Feature-103956-IntroduceInstallpasswordsetCommand.rst:38 Reply

    If you provide --password=my-password it will hash it and place it If you do not provide a password it will generate one for you

    PasswordSetCommand.php:99 Reply

    This was a mistake, i already fixed that in my later patch. I decided that doing `--password=` does not need some behaviour. No matter what is done in this case, it seems weird. So I throw now an exception: "Must not provide empty password as argument".
  33. Rozbeh Chiryai Sharahi commented on patch set 11 06/12/24, 15:55

    Feature-103956-IntroduceInstallpasswordsetCommand.rst:6 Reply

    Thanks for checking that. I am still a bit overwhelmed by documentation. Will try now to fix that.

    Feature-103956-IntroduceInstallpasswordsetCommand.rst:47 Reply

    thank you <3. I updated the message
  34. Rozbeh Chiryai Sharahi updated the commit message in patch set 12 06/12/24, 15:55

  35. core-ci voted on patch set 11 V +1 06/12/24, 15:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59343

  36. Rozbeh Chiryai Sharahi uploaded patch set 13 06/12/24, 16:01

  37. Rozbeh Chiryai Sharahi commented on patch set 12 06/12/24, 16:01

    Feature-103956-IntroduceInstallpasswordsetCommand.rst:6 Reply

    Aaaaah now I see what you mean. I just fixed the number.
  38. core-ci voted on patch set 12 V +1 06/12/24, 16:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59346

  39. core-ci voted on patch set 13 V +1 06/12/24, 16:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59349

  40. Garvin Hicking commented on patch set 13 06/12/24, 16:25

    Thanks for iterating on this, resolved some comments. Couldn't test the latest iteration with empty/unset/0/null passwords, but I have hopes this works now. I'm sure Stefan will decide on the final implementation with a keen eye. :-)

    Feature-103956-IntroduceInstallpasswordsetCommand.rst:6 Reply

    Done

    Feature-103956-IntroduceInstallpasswordsetCommand.rst:38 Reply

    Done

    Feature-103956-IntroduceInstallpasswordsetCommand.rst:47 Reply

    I think this one is still missing, it shows "no impact" for me in the latest version?

    PasswordSetCommand.php:79 Reply

    Done

    PasswordSetCommand.php:99 Reply

    That's a good solution, yes!
  41. Simon Schaufelberger updated the commit message in patch set 14 V +1 06/12/24, 17:38

  42. Simon Schaufelberger commented on patch set 14 CR -1 06/12/24, 17:41

    PasswordSetCommand.php:78

    please do not use is_null but use null comparison
  43. core-ci voted on patch set 14 V +1 06/12/24, 17:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59360

  44. Rozbeh Chiryai Sharahi uploaded patch set 15 CR -1 V +1 06/12/24, 17:51

  45. Rozbeh Chiryai Sharahi commented on patch set 14 06/12/24, 17:51

    PasswordSetCommand.php:78 Reply

    Done
  46. core-ci voted on patch set 15 V +1 06/12/24, 17:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59361

  47. Garvin Hicking commented on patch set 15 06/12/24, 18:04

    Feature-103956-IntroduceInstallpasswordsetCommand.rst:47 Reply

    Done
  48. Simon Schaufelberger commented on patch set 15 06/12/24, 21:12

    PasswordSetCommand.php:107

    I would rather print something like: "QuestionHelper could not be loaded"
  49. Garvin Hicking commented on patch set 15 06/12/24, 21:18

    PasswordSetCommand.php:107 Reply

    Speaking of - in which cases would these even happen? Are there symfony versions which are compatible but do not provide it? or is it shell/terminal dependant if the heloer is available?
  50. Rozbeh Chiryai Sharahi uploaded patch set 16 V +1 06/12/24, 21:35

  51. Rozbeh Chiryai Sharahi commented on patch set 15 06/12/24, 21:37

    PasswordSetCommand.php:107 Reply

    getHelper('question') return type returns a HelperInterface. So _theoretically_ IDE and php do not know that it will be a QuestionHelper. In future symfony versions, if ever, there might be a different instance comming out it will break as the methods return type expects a QuestionHelper. For me this is just a more controlled way to throw an exception saying "QuestionHelper could not be loaded", than expected return-type QuestionHelper but got something else. This was just the background of "why I did it that way". For now I addressed as @simonschaufi+typo3@gmail.com mentioned the exception-message. If you feel like it is better to dismiss the if-statement entirely, please let me know.
  52. core-ci voted on patch set 16 V +1 06/12/24, 21:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59372

  53. Georg Ringer commented on patch set 16 06/13/24, 05:55

    Feature-104058-IntroduceInstallpasswordsetCommand.rst:48

    it is called Install Tool, please adopt it on other places as well

    PasswordSetInvalidInputException.php:3

    declare strict missing

    PasswordSetCommand.php:86

    instead of "" and variable substitution we prefer sprintf IMHO, also below

    PasswordSetCommand.php:94

    should we add a info message that the password is set as well?

    PasswordSetCommandTest.php:3

    declare strict
  54. Rozbeh Chiryai Sharahi commented on patch set 16 06/13/24, 07:51

    Feature-104058-IntroduceInstallpasswordsetCommand.rst:48 Reply

    Hey, wow, thanks for the Review! Will address that all.
  55. Rozbeh Chiryai Sharahi uploaded patch set 17 V +1 06/13/24, 08:13

  56. Rozbeh Chiryai Sharahi commented on patch set 16 06/13/24, 08:14

    Feature-104058-IntroduceInstallpasswordsetCommand.rst:48 Reply

    Done

    PasswordSetInvalidInputException.php:3 Reply

    Done

    PasswordSetCommand.php:86 Reply

    Done

    PasswordSetCommand.php:94 Reply

    Ah yeah. I did that.

    PasswordSetCommandTest.php:3 Reply

    Done
  57. core-ci voted on patch set 17 V -1 06/13/24, 08:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59422

  58. Rozbeh Chiryai Sharahi uploaded patch set 18 V -1 06/13/24, 08:33

  59. core-ci voted on patch set 18 V -1 06/13/24, 08:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59427

  60. Rozbeh Chiryai Sharahi uploaded patch set 19 V -1 06/13/24, 08:42

  61. Rozbeh Chiryai Sharahi updated the commit message in patch set 20 06/13/24, 08:44

  62. core-ci voted on patch set 19 V +1 06/13/24, 08:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59429

  63. core-ci voted on patch set 20 V +1 06/13/24, 08:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59431

  64. Stefan Bürk commented on patch set 20 CR -1 06/13/24, 14:25

    ConsoleHelperNotFoundException.php:3

    Superflous - see comment in other file, this exception is not needed.

    PasswordSetInvalidInputException.php:2

    Missing a `declare(strict_types=1);`

    PasswordSetCommand.php:49

    I'm not a fan of having the write option as default. It would be better to have a option to explicity tell the command to write it (and at best to have the option to choose between `settings.php` or appending(creating) it to the `additional.php`. Having the not "destructive" option as default is better.

    PasswordSetCommand.php:107 Reply

    Adding this check and intruducing a dedicated exception class here does not make much sense. It does not help a user anyway and needs to be adressed in the core. Usually we simply use ``` /** @var QuestionHelper $questionHelper */ $questionHelper = $this->getHelper('question'); ``` if a method would not exists due to having a invalid class it would fail anyway. By putting it into a dedicated getter method you already added the check, so that manual check is here useless. A "Class xx is not compatible to xy" like type exception/fatal makes it more clear than the "unexpected helper retrieved" here. IMO such a change would pop up on symfony raises anyway, I'd say and thus fixed in the core before a release. Just ensure to add a test covering the helper retrival. I would remove the dedicated excpetion and check here and let the normal type check (return type) do the job.

    PasswordSetCommandTest.php:30

    Please add the new command also to the generic cli command testing in `\TYPO3\CMS\Core\Tests\Functional\Command\CliCommandTest`

    PasswordSetCommandTest.php:69

    File should be a) saved b) checked for changes c) restored to not pullate the functional testcase instance (as a safeguard)
  65. Stefan Bürk commented on patch set 20 06/13/24, 15:02

    PasswordSetCommandTest.php:37

    +1 for not using TestCase properites for command/application creation and forgetting to tear them down. Nice.
  66. Rozbeh Chiryai Sharahi commented on patch set 20 06/13/24, 16:15

    ConsoleHelperNotFoundException.php:3 Reply

    Super nice, thx for the review. Will address all this now.
  67. Rozbeh Chiryai Sharahi commented on patch set 20 06/13/24, 16:22

    PasswordSetInvalidInputException.php:2 Reply

    This was already solved in a more recent changeset, don't know why your comment is address change-set 15.
  68. Rozbeh Chiryai Sharahi uploaded patch set 21 CR -1 V +1 06/13/24, 16:57

  69. Rozbeh Chiryai Sharahi commented on patch set 21 06/13/24, 16:59

    ConsoleHelperNotFoundException.php:3 Reply

    Done

    PasswordSetCommand.php:49 Reply

    As we discussed in person, this would be addressed in an additional change to keep the scope down.

    PasswordSetCommand.php:107 Reply

    Done

    PasswordSetCommandTest.php:30 Reply

    Done

    PasswordSetCommandTest.php:69 Reply

    Done
  70. Rozbeh Chiryai Sharahi commented on patch set 21 06/13/24, 16:59

    Reply

    Done
  71. core-ci voted on patch set 21 V +1 06/13/24, 17:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59516

  72. Stefan Bürk voted on patch set 21 CR +1 V +1 06/13/24, 18:38

  73. Georg Ringer commented on patch set 22 CR +1 V +1 06/13/24, 18:53

    Published edit on patch set 21.
  74. Georg Ringer voted on patch set 22 CR +1 V +1 06/13/24, 18:53

  75. core-ci voted on patch set 22 V +1 06/13/24, 18:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59534

  76. Garvin Hicking commented on patch set 22 CR -1 06/13/24, 18:57

    Feature rst does not match current arguments / logic (writr vs dry)
  77. Rozbeh Chiryai Sharahi uploaded patch set 23 CR +1 V +1 06/13/24, 19:22

  78. Rozbeh Chiryai Sharahi commented on patch set 23 06/13/24, 19:22

    Reply

    jeeeeess, good eyes. 😄
  79. core-ci voted on patch set 23 V +1 06/13/24, 19:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59539

  80. Stefan Bürk voted on patch set 23 CR +1 V +1 06/13/24, 19:33

  81. Benjamin Franzke commented on patch set 23 CR -1 06/13/24, 19:53

    Feature-104058-IntroduceInstallpasswordsetCommand.rst:37

    Let's avoid a password flag, passwords need to be read via interactive input. Reasons: Password can be read from shell history and the process list.
  82. Stefan Bürk voted on patch set 23 CR 0 V 0 06/13/24, 20:01

  83. Rozbeh Chiryai Sharahi commented on patch set 23 06/13/24, 20:10

    Feature-104058-IntroduceInstallpasswordsetCommand.rst:37 Reply

    Hey, thx for the last minute catch 😄 ok i can do that. I don't remember why I added the `--password` option. Probably because I thought someone might want to set the password via CI in some weird scenarios. If setting a password programmatically is ever needed, than It will be a different patch 😊
  84. Garvin Hicking commented on patch set 23 06/13/24, 20:37

    Feature-104058-IntroduceInstallpasswordsetCommand.rst:37 Reply

    Actually I would like if deployments and scripting could set install passwords programmatically via the CLI; docker instances could profit from it? at least passing it via ENV var if not command line argument...?
  85. Rozbeh Chiryai Sharahi commented on patch set 23 06/13/24, 20:53

    Feature-104058-IntroduceInstallpasswordsetCommand.rst:37 Reply

    I was also considering env vars. Nevertheless is it ok for you to simply do this in a separate patch? I can follow up directly with such a patch, where we can fully focus on that one issue.
  86. Garvin Hicking commented on patch set 23 06/13/24, 20:59

    Feature-104058-IntroduceInstallpasswordsetCommand.rst:37 Reply

    Sure, sorry - wasn't mean as a blocking issue, just a comment. I'm good to +1 either way, Stefan&Benjamin lead the way :)
  87. Rozbeh Chiryai Sharahi uploaded patch set 24 CR -1 V +1 06/13/24, 21:03

  88. Rozbeh Chiryai Sharahi commented on patch set 24 06/13/24, 21:04

    Feature-104058-IntroduceInstallpasswordsetCommand.rst:37 Reply

    Cool. So I removed the password option now (AND updated docs :D ).
  1. core-ci voted on patch set 24 V +1 06/13/24, 21:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59543

  2. Garvin Hicking commented on patch set 24 CR +1 V +1 06/13/24, 21:11

    Feature-104058-IntroduceInstallpasswordsetCommand.rst:37 Reply

    Thinking about it; with a randomly generated password one can also do scripting; catch the output and operate on that. That could do for at least the deployment scenario I have in mind. Great you had the energy and motivation to keep this patch up. I promise you it's not always that hard 😅
  3. Simon Schaufelberger wrote 06/13/24, 21:31

    Removed reviewer Simon Schaufelberger.
  4. Rozbeh Chiryai Sharahi commented on patch set 24 06/14/24, 07:59

    @stefan@buerk.tech @gh@faktor-e.de Does it make sense to first change the output format on default to json or yaml, so it is easier for machine learning? @stefan@buerk.tech brought me to this idea. I think for instance yaml is easy to read and also machine readable. Even json i think is fine, as it is an admin tool. (I can also introduce some output option: --output=json|yaml|human-readable
  5. Georg Ringer commented on patch set 24 06/14/24, 08:27

    Reply

    i am not sure if we should to add this for one single command?!
  6. Rozbeh Chiryai Sharahi commented on patch set 24 06/14/24, 10:14

    Reply

    Ok. Will resolve this again.
  7. Simon Schaufelberger uploaded patch set 25 CR +1 V +1 08/06/24, 16:13

  8. core-ci voted on patch set 25 V +1 08/06/24, 16:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62958

  9. Garvin Hicking commented on patch set 25 CR +1 V +1 08/07/24, 08:40

    IMO this is quite well now! Tested again.
  10. Stefan Bürk commented on patch set 25 CR -1 08/07/24, 16:46

    Feature-104058-IntroduceInstallpasswordsetCommand.rst:37 Reply

    Before merging, @ben@bnf.dev should re-review this patch all his concerns has been solved properly. Thus -1 on this.
  11. Simon Schaufelberger commented on patch set 25 08/29/24, 12:10

    Feature-104058-IntroduceInstallpasswordsetCommand.rst:37 Reply

    ping @ben@bnf.dev
  12. Juliane Wundermann uploaded patch set 26 CR +1 V +1 05/05/25, 21:50

  13. core-ci voted on patch set 26 V +1 05/05/25, 22:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78558

  14. Benjamin Franzke commented on patch set 26 06/26/25, 18:15

    PasswordSetCommand.php:48

    I'd expect the command to *set* the password without any arguments supplied, having to specifiy `-w` explicitly is not intuitive. I'd rather see a `--dry-run` that would only print the hash, if specified, without saving it.

    PasswordSetCommand.php:71

    Hm, I feel like randomization should only be offered if explicitly requested via commandline flag (`-r/--random`). It's to easy to just click ENTER and have the password randomized without intent.

    PasswordSetCommand.php:78

    Let's not print the password hash if the password is written, it's not useful in this case and I'd rather not print hashes to the console if not actually needed.
  15. Garvin Hicking commented on patch set 26 CR -1 06/27/25, 07:49

    on it
  16. Garvin Hicking commented on patch set 26 CR +1 V +1 06/27/25, 08:50

    Adjusted the patch: - Write settings by default - Remove "--write" option in favor of reversed "--dry-run" logic - Only show password hash in "--no-interaction" mode - Reworked tests to match new workflows - Ensured tests have setUp/tearDown to preserve settings file and test for changes, using password validation. Added also checking the combined "no-interaction&dry-run" mode - Adapted docs, added note for CI/CD automation - Rebased, resolved conflicts
  17. Garvin Hicking commented on patch set 26 06/27/25, 08:54

    Reply

    Done

    Feature-104058-IntroduceInstallpasswordsetCommand.rst:37 Reply

    Done

    PasswordSetCommand.php:48 Reply

    I see. This was the original setup but changed during the patch. However I do agree that when the command says "password:set" its default operation should not be to only do "password:dryset". ;)

    PasswordSetCommand.php:71 Reply

    "--no-interaction" is basically the "--random" option, so we have that for intentional randmomizing. I do think that for the CLI feedback its a nice option to also use randomizing because people are used to having fallbacks kick in on empty inputs in a lot of Symfony commands. I would argue that this has a benefit so you can still decide on the "interaction" variant if you want to enter a password or let it get randomized. wdyt?

    PasswordSetCommand.php:78 Reply

    Ack. I've changed this so only for dry-run the hash is emitted (for possible CI/CD automation, and also for the functional tests).
  18. Garvin Hicking uploaded patch set 27 CR +1 V +1 06/27/25, 08:57

  19. Garvin Hicking voted on patch set 27 CR +1 V +1 06/27/25, 08:57

  20. core-ci voted on patch set 27 V +1 06/27/25, 09:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81064

  21. Benjamin Franzke uploaded patch set 28 CR +1 V +1 07/04/25, 08:54

  22. Benjamin Franzke commented on patch set 28 07/04/25, 08:54

    PasswordSetCommand.php:71 Reply

    Thanks for the refactorings, this looks very good now. Let's get it in 😊
  23. core-ci voted on patch set 28 V +1 07/04/25, 09:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81317

  24. Garvin Hicking voted on patch set 28 CR +2 V +2 07/04/25, 09:18

  25. Garvin Hicking merged patch set 29 07/04/25, 09:18