84654[FEATURE] Provide backend modules in LiveSearch
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Oli Bartsch +1
-
Verified V +2 Done
- Andreas Kienast +2
- Oli Bartsch +1
- core-ci +1 CI
Issues 1
Files 6
- Build/Sources/TypeScript/backend/live-search/result-types/backend-module-result-type.tsnew+8 −0
- typo3/sysext/backend/Classes/EventListener/AfterBackendPageRenderEventListener.php+5 −0
- typo3/sysext/backend/Classes/Search/LiveSearch/BackendModuleProvider.php16new+110 −0
- typo3/sysext/backend/Resources/Private/Language/locallang.xlf+9 −0
- typo3/sysext/backend/Resources/Public/JavaScript/live-search/result-types/backend-module-result-type.jsnew+13 −0
- typo3/sysext/core/Documentation/Changelog/13.2/Feature-92009-ProvideBackendModulesInLiveSearch.rst2new+23 −0
Review log 2738
Show 913 earlier messages
-
Andreas Nedbal uploaded patch set 1 06/12/24, 09:00
-
core-ci voted on patch set 1 V -1 06/12/24, 09:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59292
-
Andreas Nedbal uploaded patch set 2
V -106/12/24, 09:08 -
core-ci voted on patch set 2 V +1 06/12/24, 09:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59294
-
Andreas Nedbal uploaded patch set 3
V +106/12/24, 09:32 -
Mathias Brodala commented on patch set 2 CR -1 06/12/24, 09:34
BackendModuleProvider.php:61This should be done once we are sure the URI could be built.BackendModuleProvider.php:72Why not "continue;" directly here? Generally reduce the content of "try" here to the URI building.BackendModuleProvider.php:74How can the count be -1, -2 or similar? ;-) -
core-ci voted on patch set 3 V +1 06/12/24, 09:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59297
-
Andreas Nedbal uploaded patch set 4
V +106/12/24, 09:43 -
Andreas Nedbal commented on patch set 4 06/12/24, 09:44
BackendModuleProvider.php:60ReplyDoneBackendModuleProvider.php:61ReplyDoneBackendModuleProvider.php:72ReplyDoneBackendModuleProvider.php:74ReplyDone -
Andreas Kienast commented on patch set 4 06/12/24, 09:46
BackendModuleProvider.php:104``` /** * @return list<ModuleInterface> */ ``` This should make the explicit `@var` annotation above obsolete.BackendModuleProvider.php:110You could use `fn()` instead, this makes the requirement for `use()` obsolete. -
core-ci voted on patch set 4 V +1 06/12/24, 09:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59302
-
Andreas Nedbal uploaded patch set 5
V +106/12/24, 09:51 -
Andreas Nedbal commented on patch set 5 06/12/24, 09:51
BackendModuleProvider.php:104ReplyDoneBackendModuleProvider.php:110ReplyDone
-
core-ci voted on patch set 5 V -1 06/12/24, 09:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59303
-
Oli Bartsch uploaded patch set 6
V -106/12/24, 09:57 -
Oli Bartsch uploaded patch set 7 06/12/24, 09:59
-
Oli Bartsch commented on patch set 7 06/12/24, 10:01
BackendModuleProvider.php:91I don't see the reason for caching the modules at this place, since this class does no special operation or applies any constraints to the getModules() result. IMO win case we want to use a cache, this should be implemented in the ModuleProvider directly. -
core-ci voted on patch set 6 V -1 06/12/24, 10:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59305
-
core-ci voted on patch set 7 V +1 06/12/24, 10:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59306
-
Mathias Brodala commented on patch set 7 06/12/24, 10:09
BackendModuleProvider.php:72Please reduce the content of "try" to the bare minimum. Otherwise it is hard to understand where the exception may occur. Also for the (not likely but possible) event that other code locations throw the same exception you will also silently drop that. The exception should occur in this case instead. -
Andreas Nedbal uploaded patch set 8
V +106/12/24, 10:13 -
Andreas Nedbal commented on patch set 8 06/12/24, 10:14
BackendModuleProvider.php:91ReplyDone -
core-ci voted on patch set 8 V +1 06/12/24, 10:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59308
-
Andreas Nedbal uploaded patch set 9
V +106/12/24, 10:24 -
Mathias Brodala commented on patch set 9 06/12/24, 10:29
BackendModuleProvider.php:72ReplyDone -
core-ci voted on patch set 9 V +1 06/12/24, 10:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59310
-
Guido Schmechel commented on patch set 9 06/12/24, 10:31
Feature-92009-ProvideBackendModulesInLiveSearch.rst:14listing? -
Andreas Nedbal uploaded patch set 10
V +106/12/24, 10:37 -
Andreas Nedbal commented on patch set 10 06/12/24, 10:39
Feature-92009-ProvideBackendModulesInLiveSearch.rst:14ReplyDone -
core-ci voted on patch set 10 V +1 06/12/24, 10:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59312
-
Oli Bartsch voted on patch set 10 CR +1 V +1 06/12/24, 12:10
-
Andreas Kienast commented on patch set 10 CR -1 06/14/24, 17:40
on it -
Andreas Kienast uploaded patch set 11
CR +1V +106/14/24, 18:13 -
core-ci voted on patch set 11 V +1 06/14/24, 18:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59616
-
Andreas Kienast voted on patch set 11 CR +1 V +1 06/14/24, 18:22
-
Oli Bartsch voted on patch set 11 CR +1 V +1 06/14/24, 18:29
-
Andreas Kienast voted on patch set 11 CR +2 V +2 06/15/24, 13:39
-
Andreas Kienast merged patch set 12 06/15/24, 13:39
BackendModuleProvider.php:60