Review main Merged

84654[FEATURE] Provide backend modules in LiveSearch

Andreas Nedbal CR +2 V +2 Normal +168 −0 updated 06/15/24, 13:39

Commit message

Backend users can now search for the backend modules they have
access to in the LiveSearch.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 2738

Show 913 earlier messages
  1. Andreas Nedbal uploaded patch set 1 06/12/24, 09:00

  2. core-ci voted on patch set 1 V -1 06/12/24, 09:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59292

  3. Andreas Nedbal uploaded patch set 2 V -1 06/12/24, 09:08

  4. core-ci voted on patch set 2 V +1 06/12/24, 09:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59294

  5. Andreas Nedbal uploaded patch set 3 V +1 06/12/24, 09:32

  6. Mathias Brodala commented on patch set 2 CR -1 06/12/24, 09:34

    BackendModuleProvider.php:60

    This could be replaced by $moduleUrl, see below.

    BackendModuleProvider.php:61

    This should be done once we are sure the URI could be built.

    BackendModuleProvider.php:72

    Why not "continue;" directly here? Generally reduce the content of "try" here to the URI building.

    BackendModuleProvider.php:74

    How can the count be -1, -2 or similar? ;-)
  7. core-ci voted on patch set 3 V +1 06/12/24, 09:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59297

  8. Andreas Nedbal uploaded patch set 4 V +1 06/12/24, 09:43

  9. Andreas Nedbal commented on patch set 4 06/12/24, 09:44

    BackendModuleProvider.php:60 Reply

    Done

    BackendModuleProvider.php:61 Reply

    Done

    BackendModuleProvider.php:72 Reply

    Done

    BackendModuleProvider.php:74 Reply

    Done
  10. Andreas Kienast commented on patch set 4 06/12/24, 09:46

    BackendModuleProvider.php:104

    ``` /** * @return list<ModuleInterface> */ ``` This should make the explicit `@var` annotation above obsolete.

    BackendModuleProvider.php:110

    You could use `fn()` instead, this makes the requirement for `use()` obsolete.
  11. core-ci voted on patch set 4 V +1 06/12/24, 09:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59302

  12. Andreas Nedbal uploaded patch set 5 V +1 06/12/24, 09:51

  13. Andreas Nedbal commented on patch set 5 06/12/24, 09:51

    BackendModuleProvider.php:104 Reply

    Done

    BackendModuleProvider.php:110 Reply

    Done
  1. core-ci voted on patch set 5 V -1 06/12/24, 09:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59303

  2. Oli Bartsch uploaded patch set 6 V -1 06/12/24, 09:57

  3. Oli Bartsch uploaded patch set 7 06/12/24, 09:59

  4. Oli Bartsch commented on patch set 7 06/12/24, 10:01

    BackendModuleProvider.php:91

    I don't see the reason for caching the modules at this place, since this class does no special operation or applies any constraints to the getModules() result. IMO win case we want to use a cache, this should be implemented in the ModuleProvider directly.
  5. core-ci voted on patch set 6 V -1 06/12/24, 10:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59305

  6. core-ci voted on patch set 7 V +1 06/12/24, 10:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59306

  7. Mathias Brodala commented on patch set 7 06/12/24, 10:09

    BackendModuleProvider.php:72

    Please reduce the content of "try" to the bare minimum. Otherwise it is hard to understand where the exception may occur. Also for the (not likely but possible) event that other code locations throw the same exception you will also silently drop that. The exception should occur in this case instead.
  8. Andreas Nedbal uploaded patch set 8 V +1 06/12/24, 10:13

  9. Andreas Nedbal commented on patch set 8 06/12/24, 10:14

    BackendModuleProvider.php:91 Reply

    Done
  10. core-ci voted on patch set 8 V +1 06/12/24, 10:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59308

  11. Andreas Nedbal uploaded patch set 9 V +1 06/12/24, 10:24

  12. Mathias Brodala commented on patch set 9 06/12/24, 10:29

    BackendModuleProvider.php:72 Reply

    Done
  13. core-ci voted on patch set 9 V +1 06/12/24, 10:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59310

  14. Guido Schmechel commented on patch set 9 06/12/24, 10:31

    Feature-92009-ProvideBackendModulesInLiveSearch.rst:14

    listing?
  15. Andreas Nedbal uploaded patch set 10 V +1 06/12/24, 10:37

  16. Andreas Nedbal commented on patch set 10 06/12/24, 10:39

    Feature-92009-ProvideBackendModulesInLiveSearch.rst:14 Reply

    Done
  17. core-ci voted on patch set 10 V +1 06/12/24, 10:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59312

  18. Oli Bartsch voted on patch set 10 CR +1 V +1 06/12/24, 12:10

  19. Andreas Kienast commented on patch set 10 CR -1 06/14/24, 17:40

    on it
  20. Andreas Kienast uploaded patch set 11 CR +1 V +1 06/14/24, 18:13

  21. core-ci voted on patch set 11 V +1 06/14/24, 18:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59616

  22. Andreas Kienast voted on patch set 11 CR +1 V +1 06/14/24, 18:22

  23. Oli Bartsch voted on patch set 11 CR +1 V +1 06/14/24, 18:29

  24. Andreas Kienast voted on patch set 11 CR +2 V +2 06/15/24, 13:39

  25. Andreas Kienast merged patch set 12 06/15/24, 13:39