Review main Merged

84658[TASK] Make type=link fields TEXT by default

Christian Kuhn CR +2 V +2 Easy +6 −6 updated 06/12/24, 15:37

Commit message

Similar to type=slug with #104063, type=link fields
are now set to TEXT by default. This especially saves
precious row size in tt_content due to header_link.

type=link fields can be nullable and can have default
values. Doing this with TEXT fields is possible since
issue #103578.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Stefan Bürk +1
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Stefan Bürk +1
    • Andreas Kienast +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 4

Files 2

Review log 913

  1. Christian Kuhn uploaded patch set 1 06/12/24, 11:43

  2. Christian Kuhn voted on patch set 1 CR -1 06/12/24, 11:47

  3. core-ci voted on patch set 1 V +1 06/12/24, 11:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59317

  4. Christian Kuhn updated the commit message in patch set 2 CR -1 V +1 06/12/24, 11:49

  5. core-ci voted on patch set 2 V -1 06/12/24, 11:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59318

  6. core-ci voted on patch set 2 V +1 06/12/24, 12:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59318

  7. Garvin Hicking voted on patch set 2 CR +1 V +1 06/12/24, 12:23

  8. Stefan Bürk voted on patch set 2 CR +1 V +1 06/12/24, 12:28

  9. Andreas Kienast voted on patch set 2 CR +1 V +1 06/12/24, 13:08

  10. Benni Mack voted on patch set 2 CR +1 V +1 06/12/24, 13:24

  11. core-ci commented on patch set 2 06/12/24, 13:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59328

  12. Christian Kuhn voted on patch set 2 CR +2 V +2 06/12/24, 15:37

  13. Christian Kuhn merged patch set 3 06/12/24, 15:37