Review main Merged

84659[FEATURE] Improve backend notifications display and handling

Jochen Roth CR +2 V +2 Normal +183 −9 updated 06/18/24, 15:10

Commit message

Currently, the notification/alert container does not allow scrolling
when multiple notifications exceed the viewport height and
it is not possible to clear all displayed notifications.

This has been changed to allow scrolling within the
container. On top of this, it is now also possible
to focus the container using tab and scroll up and down
using the arrow keys and clear all notifications with a
single click.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 8

Review log 3455

Show 1730 earlier messages
  1. Jochen Roth uploaded patch set 1 06/12/24, 12:30

  2. core-ci voted on patch set 1 V +1 06/12/24, 12:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59322

  3. Andreas Kienast commented on patch set 1 06/12/24, 12:45

    _root.scss:65

    Please consult @benjamin.kott@outlook.com, he invested quite some time configuring the shadows.
  4. Jochen Roth uploaded patch set 2 V +1 06/12/24, 13:27

  5. core-ci voted on patch set 2 V +1 06/12/24, 13:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59329

  6. Jochen Roth commented on patch set 2 06/12/24, 14:54

    _root.scss:65 Reply

    Done, not touching the shadow at all.
  7. Jochen Roth commented on patch set 2 CR -1 06/15/24, 11:19

    On it. Will add a "Remove all" button along with the scrolling
  8. Jochen Roth uploaded patch set 3 CR -1 V +1 06/15/24, 13:18

  9. core-ci voted on patch set 3 V -1 06/15/24, 13:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59644

  10. Jochen Roth uploaded patch set 4 V -1 06/16/24, 18:49

  11. core-ci voted on patch set 4 V -1 06/16/24, 18:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59683

  12. Jochen Roth uploaded patch set 5 V -1 06/16/24, 18:57

  13. core-ci voted on patch set 5 V -1 06/16/24, 19:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59684

  14. Jochen Roth uploaded patch set 6 V -1 06/16/24, 19:07

  15. core-ci voted on patch set 6 V -1 06/16/24, 19:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59685

  16. Jochen Roth uploaded patch set 7 V -1 06/16/24, 19:25

  17. core-ci voted on patch set 7 V -1 06/16/24, 19:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59686

  18. Jochen Roth uploaded patch set 8 V -1 06/16/24, 19:33

  19. Jochen Roth uploaded patch set 9 06/16/24, 19:34

  20. Jochen Roth uploaded patch set 10 06/16/24, 19:36

  21. core-ci voted on patch set 8 V -1 06/16/24, 19:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59687

  22. core-ci voted on patch set 9 V -1 06/16/24, 19:43 Copied votes on follow-up patch sets have been updated: * Verified-1 has been copied to patch set 10 (copy condition: "changekind:NO_CHANGE"). Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59688

  23. core-ci voted on patch set 10 V -1 06/16/24, 19:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59689

  24. Jochen Roth uploaded patch set 11 V -1 06/16/24, 19:47

  25. core-ci voted on patch set 11 V -1 06/16/24, 19:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59690

  26. Jochen Roth uploaded patch set 12 V -1 06/16/24, 20:22

  27. core-ci voted on patch set 12 V -1 06/16/24, 20:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59691

  28. Jochen Roth uploaded patch set 13 V -1 06/16/24, 20:30

  29. core-ci voted on patch set 13 V -1 06/16/24, 20:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59692

  30. Georg Ringer voted on patch set 13 CR +1 V +1 06/17/24, 05:43

  1. Jochen Roth uploaded patch set 14 CR +1 V +1 06/17/24, 06:47

  2. core-ci voted on patch set 14 V -1 06/17/24, 06:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59712

  3. Jochen Roth uploaded patch set 15 V -1 06/17/24, 06:58

  4. core-ci voted on patch set 15 V +1 06/17/24, 07:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59713

  5. Jochen Roth commented on patch set 15 06/17/24, 07:06

    @minapokhalo+typo3@gmail.com, @michael.telgkamp@mindscreen.de would be great if you could review this. This somehow turned into a feature, because we now have a "remove all" button.
  6. Oli Bartsch commented on patch set 15 06/17/24, 07:27

    Let's stick to the "close all" wording instead of "remove"

    notification.ts:189

    Let's name the button "Close all".

    Feature-104069-AllowScrollingWithinTheAlertnotificationContainer.rst:6

    Please use a shorter headline, e.g. "Improved backend notifications display and handling"

    Feature-104069-AllowScrollingWithinTheAlertnotificationContainer.rst:20

    Could we add the "Impact" section as well?
  7. Garvin Hicking uploaded patch set 16 V +1 06/17/24, 08:26

    Unify button label and docs
  8. core-ci voted on patch set 16 V +1 06/17/24, 08:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59714

  9. Garvin Hicking commented on patch set 16 CR +1 V +1 06/17/24, 08:40

    Reply

    I've had a small chat with Jochen, and we also consulted a LLM for seeing which wording is most commonly used. "Clear all" was the winner there, also mentioned was "Dismiss all". I've changed this patch to use "Clear all". If you feel this is a wrong choice, please feel free to revert/object. :-)

    notification.ts:189 Reply

    Done

    Feature-104069-AllowScrollingWithinTheAlertnotificationContainer.rst:6 Reply

    Done

    Feature-104069-AllowScrollingWithinTheAlertnotificationContainer.rst:20 Reply

    Done
  10. Garvin Hicking uploaded patch set 17 CR +1 V +1 06/17/24, 08:41

    Rename RST
  11. core-ci voted on patch set 17 V +1 06/17/24, 08:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59716

  12. Garvin Hicking voted on patch set 17 CR +1 V +1 06/17/24, 15:13

  13. Oli Bartsch uploaded patch set 18 CR +1 V +1 06/18/24, 12:14

  14. Oli Bartsch commented on patch set 18 06/18/24, 12:15

    typo3-notification-message.scss:35

    typo3-notification-clear-all

    notification.ts:35

    showClearAllButtonCount

    notification.ts:128

    typo3-notification-clear-all

    notification.ts:188

    clearAll

    notification.ts:188

    not used

    notification.ts:223

    close event, right?
  15. Oli Bartsch commented on patch set 18 CR +1 V +1 06/18/24, 12:15

    typo3-notification-message.scss:35 Reply

    Done

    notification.ts:35 Reply

    Done

    notification.ts:128 Reply

    Done

    notification.ts:188 Reply

    Done

    notification.ts:188 Reply

    Done

    notification.ts:223 Reply

    Done
  16. Garvin Hicking voted on patch set 18 CR +1 V +1 06/18/24, 12:21

  17. core-ci voted on patch set 18 V -1 06/18/24, 12:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59797

  18. core-ci commented on patch set 18 06/18/24, 12:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59797

  19. Oli Bartsch uploaded patch set 19 CR +1 V +1 06/18/24, 13:58

  20. core-ci voted on patch set 19 V -1 06/18/24, 14:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59810

  21. Oli Bartsch uploaded patch set 20 V -1 06/18/24, 14:20

  22. core-ci voted on patch set 20 V +1 06/18/24, 14:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59812

  23. Garvin Hicking voted on patch set 20 CR +1 V +1 06/18/24, 15:08

  24. Oli Bartsch voted on patch set 20 CR +2 V +2 06/18/24, 15:10

  25. Oli Bartsch merged patch set 21 06/18/24, 15:10