84659[FEATURE] Improve backend notifications display and handling
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Garvin Hicking +1
-
Verified V +2 Done
- Oli Bartsch +2
- Garvin Hicking +1
- core-ci +1 CI
Issues 1
Files 8
- Build/Sources/Sass/element/typo3-notification-message.scss2+15 −0
- Build/Sources/TypeScript/backend/tests/notification-test.ts+1 −1
- Build/Sources/TypeScript/backend/notification.ts12+79 −5
- typo3/sysext/adminpanel/Resources/Private/Language/locallang.xlf+3 −0
- typo3/sysext/backend/Resources/Public/Css/backend.css+3 −0
- typo3/sysext/backend/Resources/Public/JavaScript/notification.js+5 −3
- typo3/sysext/core/Documentation/Changelog/13.2/Feature-104069-ImprovedBackendNotificationsDisplayAndHandling.rstnew+27 −0
- typo3/sysext/core/Tests/Acceptance/Application/Styleguide/NotificationCest.phpnew+50 −0
Review log 3455
Show 1730 earlier messages
-
Jochen Roth uploaded patch set 1 06/12/24, 12:30
-
core-ci voted on patch set 1 V +1 06/12/24, 12:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59322
-
Andreas Kienast commented on patch set 1 06/12/24, 12:45
-
Jochen Roth uploaded patch set 2
V +106/12/24, 13:27 -
core-ci voted on patch set 2 V +1 06/12/24, 13:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59329
-
Jochen Roth commented on patch set 2 06/12/24, 14:54
_root.scss:65ReplyDone, not touching the shadow at all. -
Jochen Roth commented on patch set 2 CR -1 06/15/24, 11:19
On it. Will add a "Remove all" button along with the scrolling -
Jochen Roth uploaded patch set 3
CR -1V +106/15/24, 13:18 -
core-ci voted on patch set 3 V -1 06/15/24, 13:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59644
-
Jochen Roth uploaded patch set 4
V -106/16/24, 18:49 -
core-ci voted on patch set 4 V -1 06/16/24, 18:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59683
-
Jochen Roth uploaded patch set 5
V -106/16/24, 18:57 -
core-ci voted on patch set 5 V -1 06/16/24, 19:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59684
-
Jochen Roth uploaded patch set 6
V -106/16/24, 19:07 -
core-ci voted on patch set 6 V -1 06/16/24, 19:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59685
-
Jochen Roth uploaded patch set 7
V -106/16/24, 19:25 -
core-ci voted on patch set 7 V -1 06/16/24, 19:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59686
-
Jochen Roth uploaded patch set 8
V -106/16/24, 19:33 -
Jochen Roth uploaded patch set 9 06/16/24, 19:34
-
Jochen Roth uploaded patch set 10 06/16/24, 19:36
-
core-ci voted on patch set 8 V -1 06/16/24, 19:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59687
-
core-ci voted on patch set 9 V -1 06/16/24, 19:43 Copied votes on follow-up patch sets have been updated: * Verified-1 has been copied to patch set 10 (copy condition: "changekind:NO_CHANGE"). Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59688
-
core-ci voted on patch set 10 V -1 06/16/24, 19:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59689
-
Jochen Roth uploaded patch set 11
V -106/16/24, 19:47 -
core-ci voted on patch set 11 V -1 06/16/24, 19:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59690
-
Jochen Roth uploaded patch set 12
V -106/16/24, 20:22 -
core-ci voted on patch set 12 V -1 06/16/24, 20:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59691
-
Jochen Roth uploaded patch set 13
V -106/16/24, 20:30 -
core-ci voted on patch set 13 V -1 06/16/24, 20:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59692
-
Georg Ringer voted on patch set 13 CR +1 V +1 06/17/24, 05:43
-
Jochen Roth uploaded patch set 14
CR +1V +106/17/24, 06:47 -
core-ci voted on patch set 14 V -1 06/17/24, 06:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59712
-
Jochen Roth uploaded patch set 15
V -106/17/24, 06:58 -
core-ci voted on patch set 15 V +1 06/17/24, 07:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59713
-
Jochen Roth commented on patch set 15 06/17/24, 07:06
@minapokhalo+typo3@gmail.com, @michael.telgkamp@mindscreen.de would be great if you could review this. This somehow turned into a feature, because we now have a "remove all" button. -
Oli Bartsch commented on patch set 15 06/17/24, 07:27
Let's stick to the "close all" wording instead of "remove"notification.ts:189Let's name the button "Close all".Feature-104069-AllowScrollingWithinTheAlertnotificationContainer.rst:6Please use a shorter headline, e.g. "Improved backend notifications display and handling"Feature-104069-AllowScrollingWithinTheAlertnotificationContainer.rst:20Could we add the "Impact" section as well? -
Garvin Hicking uploaded patch set 16
V +106/17/24, 08:26Unify button label and docs -
core-ci voted on patch set 16 V +1 06/17/24, 08:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59714
-
Garvin Hicking commented on patch set 16 CR +1 V +1 06/17/24, 08:40
Reply
I've had a small chat with Jochen, and we also consulted a LLM for seeing which wording is most commonly used. "Clear all" was the winner there, also mentioned was "Dismiss all". I've changed this patch to use "Clear all". If you feel this is a wrong choice, please feel free to revert/object. :-)notification.ts:189ReplyDoneFeature-104069-AllowScrollingWithinTheAlertnotificationContainer.rst:6ReplyDoneFeature-104069-AllowScrollingWithinTheAlertnotificationContainer.rst:20ReplyDone -
Garvin Hicking uploaded patch set 17
CR +1V +106/17/24, 08:41Rename RST -
core-ci voted on patch set 17 V +1 06/17/24, 08:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59716
-
Garvin Hicking voted on patch set 17 CR +1 V +1 06/17/24, 15:13
-
Oli Bartsch uploaded patch set 18
CR +1V +106/18/24, 12:14 -
Oli Bartsch commented on patch set 18 06/18/24, 12:15
typo3-notification-message.scss:35typo3-notification-clear-allnotification.ts:35showClearAllButtonCountnotification.ts:128typo3-notification-clear-allnotification.ts:188clearAllnotification.ts:188not usednotification.ts:223close event, right? -
Oli Bartsch commented on patch set 18 CR +1 V +1 06/18/24, 12:15
typo3-notification-message.scss:35ReplyDonenotification.ts:35ReplyDonenotification.ts:128ReplyDonenotification.ts:188ReplyDonenotification.ts:188ReplyDonenotification.ts:223ReplyDone -
Garvin Hicking voted on patch set 18 CR +1 V +1 06/18/24, 12:21
-
core-ci voted on patch set 18 V -1 06/18/24, 12:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59797
-
core-ci commented on patch set 18 06/18/24, 12:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59797
-
Oli Bartsch uploaded patch set 19
CR +1V +106/18/24, 13:58 -
core-ci voted on patch set 19 V -1 06/18/24, 14:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59810
-
Oli Bartsch uploaded patch set 20
V -106/18/24, 14:20 -
core-ci voted on patch set 20 V +1 06/18/24, 14:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59812
-
Garvin Hicking voted on patch set 20 CR +1 V +1 06/18/24, 15:08
-
Oli Bartsch voted on patch set 20 CR +2 V +2 06/18/24, 15:10
-
Oli Bartsch merged patch set 21 06/18/24, 15:10
_root.scss:65