84660[TASK] Improve accessibility of "Dashboard" backend module
Commit message
Review
-
Code review CR +2 Done
- Jasmina Ließmann +2
- Christian Kuhn +1
-
Verified V +2 Done
- Jasmina Ließmann +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 8
- Build/Sources/Sass/dashboard/_header.scss+18 −5
- Build/Sources/Sass/dashboard/_module.scss+0 −7
- Build/Sources/Sass/dashboard/_widget.scss+4 −0
- typo3/sysext/dashboard/Resources/Private/Language/locallang.xlf+3 −0
- typo3/sysext/dashboard/Resources/Private/Layouts/Widget/Widget.html+1 −1
- typo3/sysext/dashboard/Resources/Private/Layouts/Module.html+61 −47
- typo3/sysext/dashboard/Resources/Private/Templates/Dashboard/Main.html+1 −1
- typo3/sysext/dashboard/Resources/Public/Css/dashboard.css+6 −3
Review log 1117
-
Christian Rath-Ulrich uploaded patch set 1 06/12/24, 12:43
-
core-ci voted on patch set 1 V +1 06/12/24, 12:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59324
-
Georg Ringer commented on patch set 1 CR -1 07/16/24, 14:04
please check with the ux-team (if not happened already). Me personally don't like that as now on a small screen, even more space is wasted showing "Dashboard "My dashboard"" which is an information I get from the active tab already. -
Christian Rath-Ulrich uploaded patch set 2
CR -1V +107/16/24, 21:47 -
Christian Rath-Ulrich commented on patch set 2 07/16/24, 21:47
Reply
You definitely have a point here. i visually hide the heading, then the WCAG is satisfied and visually it is less invasive. -
core-ci voted on patch set 2 V -1 07/16/24, 21:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61650
-
Christian Rath-Ulrich rebased onto patch set 3
V -107/17/24, 14:38 -
core-ci voted on patch set 3 V +1 07/17/24, 14:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61698
-
Patrick Schriner rebased onto patch set 4
V +108/01/24, 20:24 -
core-ci voted on patch set 4 V +1 08/01/24, 20:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62644
-
Jasmina Ließmann uploaded patch set 5
V +108/06/24, 12:07 -
Jasmina Ließmann uploaded patch set 6 08/06/24, 12:09
-
core-ci voted on patch set 5 V -1 08/06/24, 12:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62918
-
core-ci voted on patch set 6 V +1 08/06/24, 12:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62919
-
Christian Kuhn voted on patch set 6 CR +1 V +1 08/06/24, 12:46
-
Jasmina Ließmann voted on patch set 6 CR +2 V +2 08/06/24, 17:19
-
Jasmina Ließmann merged patch set 7 08/06/24, 17:29