Review main Merged

84660[TASK] Improve accessibility of "Dashboard" backend module

Christian Rath-Ulrich CR +2 V +2 Normal +94 −64 updated 08/06/24, 17:29

Commit message

The heading structure in the "Dashboard" backend module has been
updated and a hidden h1 has been added. Additionally, role
attributes have been added to various elements.

Review

  • Code review CR +2 Done
    • Jasmina Ließmann +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Jasmina Ließmann +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 8

Review log 1117

  1. Christian Rath-Ulrich uploaded patch set 1 06/12/24, 12:43

  2. core-ci voted on patch set 1 V +1 06/12/24, 12:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59324

  3. Georg Ringer commented on patch set 1 CR -1 07/16/24, 14:04

    please check with the ux-team (if not happened already). Me personally don't like that as now on a small screen, even more space is wasted showing "Dashboard "My dashboard"" which is an information I get from the active tab already.
  4. Christian Rath-Ulrich uploaded patch set 2 CR -1 V +1 07/16/24, 21:47

  5. Christian Rath-Ulrich commented on patch set 2 07/16/24, 21:47

    Reply

    You definitely have a point here. i visually hide the heading, then the WCAG is satisfied and visually it is less invasive.
  6. core-ci voted on patch set 2 V -1 07/16/24, 21:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61650

  7. Christian Rath-Ulrich rebased onto patch set 3 V -1 07/17/24, 14:38

  8. core-ci voted on patch set 3 V +1 07/17/24, 14:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61698

  9. Patrick Schriner rebased onto patch set 4 V +1 08/01/24, 20:24

  10. core-ci voted on patch set 4 V +1 08/01/24, 20:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62644

  11. Jasmina Ließmann uploaded patch set 5 V +1 08/06/24, 12:07

  12. Jasmina Ließmann uploaded patch set 6 08/06/24, 12:09

  13. core-ci voted on patch set 5 V -1 08/06/24, 12:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62918

  14. core-ci voted on patch set 6 V +1 08/06/24, 12:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62919

  15. Christian Kuhn voted on patch set 6 CR +1 V +1 08/06/24, 12:46

  16. Jasmina Ließmann voted on patch set 6 CR +2 V +2 08/06/24, 17:19

  17. Jasmina Ließmann merged patch set 7 08/06/24, 17:29