Review main Merged

84668[TASK] Reduce memory usage of a greedy unit test

Christian Kuhn CR +2 V +2 Easy +13 −37 updated 06/12/24, 18:35

Commit message

> Build/Scripts/runTests.sh

Before:
Memory: 469.06 MB

After:
Memory: 373.02 MB

Reason: phpunit executes data providers early and keeps
data sets in memory. The "xml parser big content" tests
create megabytes of data kept in memory. Moving the data
generation from data providers to the test execution
reduces overall memory usage significantly.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Christian Kuhn uploaded patch set 1 06/12/24, 16:40

  2. core-ci voted on patch set 1 V +1 06/12/24, 16:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59356

  3. Wouter Wolters voted on patch set 1 CR +1 V +1 06/12/24, 16:56

  4. Andreas Kienast voted on patch set 1 CR +1 V +1 06/12/24, 17:13

  5. Christian Kuhn voted on patch set 1 CR +2 V +2 06/12/24, 18:35

  6. Christian Kuhn merged patch set 2 06/12/24, 18:35