Review 12.4 Merged

84669[TASK] Reduce memory usage of a greedy unit test

Christian Kuhn CR +2 V +2 Easy +13 −37 updated 06/12/24, 18:35

Commit message

> Build/Scripts/runTests.sh

Before:
Memory: 469.06 MB

After:
Memory: 373.02 MB

Reason: phpunit executes data providers early and keeps
data sets in memory. The "xml parser big content" tests
create megabytes of data kept in memory. Moving the data
generation from data providers to the test execution
reduces overall memory usage significantly.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Christian Kuhn uploaded patch set 1 06/12/24, 16:43

  2. core-ci voted on patch set 1 V +1 06/12/24, 16:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59357

  3. Christian Kuhn voted on patch set 1 CR +2 V +2 06/12/24, 18:35

  4. Christian Kuhn merged patch set 2 06/12/24, 18:35