Review main Merged

84672[TASK] Prevent requiring "typo3conf" for Composer mode in Dir. Status

Garvin Hicking CR +2 V +2 Normal +40 −33 updated 06/13/24, 10:19

Commit message

Currently both the Install Tool and Environment > Directory Status
sets the directory "typo3conf" as being mandatory and tries to
create it. This is no longer needed in Composer mode.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • Mathias Brodala +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1012

  1. Garvin Hicking uploaded patch set 1 06/13/24, 07:07

  2. Mathias Brodala commented on patch set 1 06/13/24, 07:11

    InstallStatusReport.php:94

    Maybe move this to the related condition below to completely ignore it in Composer Mode. This skips an unnecessary FS lookup.
  3. core-ci voted on patch set 1 V +1 06/13/24, 07:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59404

  4. Garvin Hicking commented on patch set 1 06/13/24, 07:28

    InstallStatusReport.php:94 Reply

    I intentionally did this to set to "0" so that IF it exists, it needs to be writable. I think there could still be extensions utilizing it...?
  5. Mathias Brodala commented on patch set 1 06/13/24, 07:34

    InstallStatusReport.php:94 Reply

    But then its the responsibility of the extensions to ensure a sane state. TYPO3 itself does not use this directory anymore and should not care about its state. So TYPO3 should not check it at all anymore.
  6. Garvin Hicking uploaded patch set 2 V +1 06/13/24, 08:51

    Apply code review suggestion
  7. Garvin Hicking commented on patch set 1 06/13/24, 08:52

    InstallStatusReport.php:94 Reply

    Ok, you've changed my mind. Is it okay like this now, enough for a vote maybe? ;)
  8. core-ci voted on patch set 2 V +1 06/13/24, 08:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59433

  9. Mathias Brodala commented on patch set 2 CR +1 06/13/24, 09:19

    InstallStatusReport.php:94 Reply

    Yup, looks good.
  10. Christian Kuhn voted on patch set 2 CR +1 V +1 06/13/24, 09:48

  11. Stefan Bürk voted on patch set 2 CR +2 V +2 06/13/24, 09:52

  12. Stefan Bürk merged patch set 3 06/13/24, 10:19