84672[TASK] Prevent requiring "typo3conf" for Composer mode in Dir. Status
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Christian Kuhn +1
- Mathias Brodala +1
-
Verified V +2 Done
- Stefan Bürk +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1012
-
Garvin Hicking uploaded patch set 1 06/13/24, 07:07
-
Mathias Brodala commented on patch set 1 06/13/24, 07:11
-
core-ci voted on patch set 1 V +1 06/13/24, 07:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59404
-
Garvin Hicking commented on patch set 1 06/13/24, 07:28
InstallStatusReport.php:94ReplyI intentionally did this to set to "0" so that IF it exists, it needs to be writable. I think there could still be extensions utilizing it...? -
Mathias Brodala commented on patch set 1 06/13/24, 07:34
InstallStatusReport.php:94ReplyBut then its the responsibility of the extensions to ensure a sane state. TYPO3 itself does not use this directory anymore and should not care about its state. So TYPO3 should not check it at all anymore. -
Garvin Hicking uploaded patch set 2
V +106/13/24, 08:51Apply code review suggestion -
Garvin Hicking commented on patch set 1 06/13/24, 08:52
InstallStatusReport.php:94ReplyOk, you've changed my mind. Is it okay like this now, enough for a vote maybe? ;) -
core-ci voted on patch set 2 V +1 06/13/24, 08:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59433
-
Mathias Brodala commented on patch set 2 CR +1 06/13/24, 09:19
InstallStatusReport.php:94ReplyYup, looks good. -
Christian Kuhn voted on patch set 2 CR +1 V +1 06/13/24, 09:48
-
Stefan Bürk voted on patch set 2 CR +2 V +2 06/13/24, 09:52
-
Stefan Bürk merged patch set 3 06/13/24, 10:19
InstallStatusReport.php:94