Review main Merged

84676[TASK] Use Autoconfigure (public and shared) attribute

Jochen Roth CR +2 V +2 Normal +87 −149 updated 06/13/24, 12:36

Commit message

Currently, Services.yaml files are used
to register a services as public and shared.

This has been changed throughout the core
(where possible) to use the PHP attribute
"Autoconfigure" (public, shared) to have
all options in one place.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Benjamin Franzke +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benjamin Franzke +1
    • core-ci +1 CI

Issues 2

Files 50

Show 30 more files

Review log 1726

Show 1 earlier messages
  1. Jochen Roth uploaded patch set 1 06/13/24, 07:26

  1. Jochen Roth commented on patch set 1 CR -1 06/13/24, 07:27

    Please do not merge before @lolli@schwarzbu.ch and @ben@bnf.dev verified/appoved!
  2. Jochen Roth updated the commit message in patch set 2 CR -1 06/13/24, 07:29

  3. Jochen Roth voted on patch set 2 CR -1 06/13/24, 07:36

  4. core-ci voted on patch set 1 V -1 06/13/24, 07:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59411

  5. core-ci voted on patch set 2 V -1 06/13/24, 07:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59412

  6. Jochen Roth uploaded patch set 3 CR -1 V -1 06/13/24, 08:48

  7. core-ci voted on patch set 3 V -1 06/13/24, 09:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59432

  8. Jochen Roth uploaded patch set 4 V -1 06/13/24, 09:05

  9. core-ci voted on patch set 4 V -1 06/13/24, 09:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59436

  10. Christian Kuhn uploaded patch set 5 V -1 06/13/24, 09:58

  11. core-ci voted on patch set 5 V -1 06/13/24, 10:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59451

  12. Christian Kuhn uploaded patch set 6 V -1 06/13/24, 10:43

  13. core-ci voted on patch set 6 V +1 06/13/24, 10:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59461

  14. Christian Kuhn voted on patch set 6 CR +1 V +1 06/13/24, 11:15

  15. Christian Kuhn updated the commit message in patch set 7 CR +1 V +1 06/13/24, 11:16

  16. Christian Kuhn commented on patch set 8 06/13/24, 11:17

    Published edit on patch set 7.
  17. Christian Kuhn voted on patch set 8 CR +1 V +1 06/13/24, 11:17

  18. core-ci voted on patch set 7 V +1 06/13/24, 11:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59469

  19. core-ci voted on patch set 8 V +1 06/13/24, 11:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59470

  20. Jochen Roth uploaded patch set 9 CR +1 V +1 06/13/24, 12:01

  21. core-ci voted on patch set 9 V +1 06/13/24, 12:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59476

  22. Benjamin Franzke voted on patch set 9 CR +1 V +1 06/13/24, 12:34

  23. Christian Kuhn voted on patch set 9 CR +1 V +1 06/13/24, 12:35

  24. Christian Kuhn voted on patch set 9 CR +2 V +2 06/13/24, 12:36

  25. Christian Kuhn merged patch set 10 06/13/24, 12:36