Review main Merged

84677[TASK] Use code editor in styleguide examples

Andreas Kienast CR +2 V +2 Easy +44 −6 updated 06/20/24, 13:22

Commit message

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jasmina Ließmann +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jasmina Ließmann +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1216

  1. Andreas Kienast uploaded patch set 1 06/13/24, 07:39

  2. core-ci voted on patch set 1 V +1 06/13/24, 07:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59417

  3. Andreas Kienast uploaded patch set 2 V +1 06/13/24, 13:21

  4. core-ci voted on patch set 2 V +1 06/13/24, 13:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59490

  5. Christian Kuhn commented on patch set 2 06/13/24, 17:13

    love it. minor glitch: the spinner icon only vanishes when the last codemirror instance scrolls into view ... well reproducible on styleguide->cards. any idea?
  6. Andreas Kienast commented on patch set 2 06/14/24, 07:08

    Reply

    Perhaps a CSS glitch due to missing FormEngine wrappers. Needs some investigation.
  7. Andreas Kienast uploaded patch set 3 V +1 06/20/24, 11:03

  8. Andreas Kienast commented on patch set 3 CR -1 06/20/24, 11:04

    code-mirror-element.ts:47

    Does not look good in FormEngine – will extract this into a separate patch, going back to v12 as well.
  9. core-ci voted on patch set 3 V +1 06/20/24, 11:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59906

  10. Andreas Kienast commented on patch set 3 06/20/24, 11:13

    code-mirror-element.ts:47 Reply

    nvm, without this patch it also looks good in FormEngine.
  11. Andreas Kienast uploaded patch set 4 CR -1 V +1 06/20/24, 11:14

  12. core-ci voted on patch set 4 V +1 06/20/24, 11:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59908

  13. Christian Kuhn voted on patch set 4 CR +1 V +1 06/20/24, 13:20

  14. Jasmina Ließmann voted on patch set 4 CR +1 V +1 06/20/24, 13:22

  15. Christian Kuhn voted on patch set 4 CR +2 V +2 06/20/24, 13:22

  16. Christian Kuhn merged patch set 5 06/20/24, 13:22