Review main Merged

84680[BUGFIX] Use correct parents property in SelectTree component

Oli Bartsch CR +2 V +2 Easy +3 −3 updated 10/21/24, 14:18

Commit message

On modernizing tree rendering, internally calculated
properties of tree nodes have been changed to start
with `__`. This patch adjusts one forgotten occurrence.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1622

  1. Oli Bartsch uploaded patch set 1 06/13/24, 08:22

  2. core-ci voted on patch set 1 V +1 06/13/24, 08:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59424

  3. Oliver Klee voted on patch set 1 CR +1 06/13/24, 08:34

  4. Christian Kuhn voted on patch set 1 CR +1 V +1 06/13/24, 09:49

  5. Andreas Kienast commented on patch set 1 06/13/24, 09:57

    select-tree.ts:103

    Why is this undefined in the first place? I'd expect at least an empty array.
  6. Andreas Kienast commented on patch set 1 CR -1 V -1 06/13/24, 13:00

    select-tree.ts:103 Reply

    `node.parents` doesn't exists at all anymore in `typo3/sysext/backend/Classes/Controller/FormSelectTreeAjaxController.php`, line 198.
  7. Benni Mack updated the commit message in patch set 2 CR +1 V +1 10/18/24, 13:32

  8. core-ci voted on patch set 2 V -1 10/18/24, 22:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67990

  9. Oli Bartsch uploaded patch set 3 V -1 10/20/24, 08:46

  10. core-ci voted on patch set 3 V +1 10/20/24, 08:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68257

  11. Oli Bartsch uploaded patch set 4 V +1 10/21/24, 08:04

  12. Oli Bartsch commented on patch set 4 10/21/24, 08:05

    select-tree.ts:103 Reply

    You're right. This information is calculated internally and stored in the `__parents` property. Adjusted the patch.
  13. core-ci voted on patch set 4 V +1 10/21/24, 08:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68282

  14. Andreas Kienast updated the commit message in patch set 5 V +1 10/21/24, 08:16

  15. core-ci voted on patch set 5 V +1 10/21/24, 08:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68283

  16. Andreas Kienast updated the commit message in patch set 6 V +1 10/21/24, 08:26

  17. Andreas Kienast voted on patch set 6 CR +1 V +1 10/21/24, 08:26

  18. core-ci voted on patch set 6 V +1 10/21/24, 08:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68286

  19. Oliver Klee wrote 10/21/24, 09:07

    Removed reviewer Oliver Klee.
  20. Christian Kuhn voted on patch set 6 CR +1 V +1 10/21/24, 14:12

  21. Oli Bartsch voted on patch set 6 CR +2 V +2 10/21/24, 14:18

  22. Oli Bartsch merged patch set 7 10/21/24, 14:18