84680[BUGFIX] Use correct parents property in SelectTree component
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Christian Kuhn +1
- Andreas Kienast +1
-
Verified V +2 Done
- Oli Bartsch +2
- Christian Kuhn +1
- Andreas Kienast +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1622
-
Oli Bartsch uploaded patch set 1 06/13/24, 08:22
-
core-ci voted on patch set 1 V +1 06/13/24, 08:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59424
-
Oliver Klee voted on patch set 1 CR +1 06/13/24, 08:34
-
Christian Kuhn voted on patch set 1 CR +1 V +1 06/13/24, 09:49
-
Andreas Kienast commented on patch set 1 06/13/24, 09:57
-
Andreas Kienast commented on patch set 1 CR -1 V -1 06/13/24, 13:00
select-tree.ts:103Reply`node.parents` doesn't exists at all anymore in `typo3/sysext/backend/Classes/Controller/FormSelectTreeAjaxController.php`, line 198. -
Benni Mack updated the commit message in patch set 2
CR +1V +110/18/24, 13:32 -
core-ci voted on patch set 2 V -1 10/18/24, 22:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67990
-
Oli Bartsch uploaded patch set 3
V -110/20/24, 08:46 -
core-ci voted on patch set 3 V +1 10/20/24, 08:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68257
-
Oli Bartsch uploaded patch set 4
V +110/21/24, 08:04 -
Oli Bartsch commented on patch set 4 10/21/24, 08:05
select-tree.ts:103ReplyYou're right. This information is calculated internally and stored in the `__parents` property. Adjusted the patch. -
core-ci voted on patch set 4 V +1 10/21/24, 08:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68282
-
Andreas Kienast updated the commit message in patch set 5
V +110/21/24, 08:16 -
core-ci voted on patch set 5 V +1 10/21/24, 08:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68283
-
Andreas Kienast updated the commit message in patch set 6
V +110/21/24, 08:26 -
Andreas Kienast voted on patch set 6 CR +1 V +1 10/21/24, 08:26
-
core-ci voted on patch set 6 V +1 10/21/24, 08:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68286
-
Oliver Klee wrote 10/21/24, 09:07
Removed reviewer Oliver Klee. -
Christian Kuhn voted on patch set 6 CR +1 V +1 10/21/24, 14:12
-
Oli Bartsch voted on patch set 6 CR +2 V +2 10/21/24, 14:18
-
Oli Bartsch merged patch set 7 10/21/24, 14:18
select-tree.ts:103