84681[TASK] Improve accessibility in ClearCacheToolbar dropdown
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Jasmina Ließmann +1
-
Verified V +2 Done
- Christian Kuhn +2
- Jasmina Ließmann +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1623
-
Christian Rath-Ulrich uploaded patch set 1 06/13/24, 09:49
-
core-ci voted on patch set 1 V +1 06/13/24, 09:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59446
-
Georg Ringer voted on patch set 1 CR +1 V +1 06/26/24, 03:59
-
Patrick Schriner commented on patch set 1 CR -1 06/26/24, 07:35
ClearCacheToolbarItemDropDown.html:19typo: -label -
Christian Rath-Ulrich uploaded patch set 2
CR +1V +107/16/24, 13:50 -
Christian Rath-Ulrich commented on patch set 2 07/16/24, 13:51
fixed spalling issuesClearCacheToolbarItemDropDown.html:6ReplyDoneClearCacheToolbarItemDropDown.html:19ReplyDone -
Georg Ringer commented on patch set 2 CR -1 07/16/24, 13:59
- why is the class dropdown-list-cache-listelement assed? seems doesnt do anything? - I now get following HTML: --- <p id="LLL:EXT:core/Resources/Private/Language/locallang_core.xlf:flushPageCachesTitle-label"> --- and --- aria-labelledby="LLL:EXT:core/Resources/Private/Language/locallang_core.xlf:flushPageCachesTitle-label"> --- which doesn't look right -
core-ci voted on patch set 2 V +1 07/16/24, 14:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61641
-
Christian Rath-Ulrich uploaded patch set 3
CR -1V +107/16/24, 22:08 -
Christian Rath-Ulrich commented on patch set 3 07/16/24, 22:10
Reply
fixed -
core-ci voted on patch set 3 V +1 07/16/24, 22:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61651
-
Jasmina Ließmann uploaded patch set 4
V +107/18/24, 18:54 -
Jasmina Ließmann updated the commit message in patch set 5 07/18/24, 18:57
-
core-ci voted on patch set 4 V -1 07/18/24, 19:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61756
-
core-ci voted on patch set 5 V -1 07/18/24, 19:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61757
-
core-ci voted on patch set 5 V +1 07/18/24, 19:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61757
-
Christian Reifenscheid commented on patch set 5 07/19/24, 08:31
Since the descriptive text explains the functionality of the link, I suggest using aria-describedby to link the description to the link. This way, the readout link is shorter, but the information is still connected. -
Christian Reifenscheid wrote 07/23/24, 05:36
Removed cc Christian Reifenscheid. -
Jasmina Ließmann uploaded patch set 6
V +108/06/24, 12:31 -
Jasmina Ließmann commented on patch set 6 CR +1 V +1 08/06/24, 12:33
Reply
Changed accordingly. -
core-ci voted on patch set 6 V +1 08/06/24, 12:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62925
-
Christian Kuhn voted on patch set 6 CR +2 V +2 08/06/24, 12:45
-
Christian Kuhn merged patch set 7 08/06/24, 13:13
ClearCacheToolbarItemDropDown.html:6