Review main Merged

84685[BUGFIX] Merge code editor settings properly

Andreas Kienast CR +2 V +2 Easy +3 −4 updated 06/13/24, 14:02

Commit message

The settings for the `typo3-t3editor-codemirror` element were passed in
an `options` attribute, which is unknown. This leads to the issue that
e.g. the `readOnly` flag set in TCA is ignored.

The composed settings are now properly merged.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Andreas Kienast uploaded patch set 1 06/13/24, 10:01

  2. core-ci voted on patch set 1 V +1 06/13/24, 10:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59452

  3. Benjamin Franzke voted on patch set 1 CR +1 V +1 06/13/24, 13:49

  4. Christian Kuhn voted on patch set 1 CR +1 V +1 06/13/24, 13:52

  5. Andreas Kienast voted on patch set 1 CR +2 V +2 06/13/24, 13:53

  6. Andreas Kienast merged patch set 2 06/13/24, 14:02