Review main Merged

84686[BUGFIX] Add aria-label to the selection options toggle button

Oli Bartsch CR +2 V +2 Easy +20 −15 updated 06/13/24, 13:10

Commit message

The toggle button to open the selection options
of the multi record selection component does now
provide an aria-label to make it accessible for
screen readers.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jasmina Ließmann +1
    • Andreas Nedbal +1
    • Michael Telgkamp +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jasmina Ließmann +1
    • Andreas Nedbal +1
    • Michael Telgkamp +1
    • core-ci +1 CI

Issues 1

Files 11

Review log 911

  1. Oli Bartsch uploaded patch set 1 06/13/24, 10:14

  2. core-ci voted on patch set 1 V +1 06/13/24, 10:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59457

  3. Michael Telgkamp commented on patch set 1 CR -1 06/13/24, 10:32

    Some additional improvements suggested.

    SelectCheckBoxElement.php:308

    As $languageService is available it should probably be used here, too.

    SelectCheckBoxElement.php:332

    As $languageService is available it should probably be used here, too.

    SelectCheckBoxElement.php:338

    As $languageService is available it should probably be used here, too.
  4. Oli Bartsch uploaded patch set 2 CR -1 V +1 06/13/24, 10:41

  5. Oli Bartsch commented on patch set 2 06/13/24, 10:47

    SelectCheckBoxElement.php:308 Reply

    Done

    SelectCheckBoxElement.php:332 Reply

    Done

    SelectCheckBoxElement.php:338 Reply

    Done
  6. core-ci voted on patch set 2 V +1 06/13/24, 10:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59460

  7. Michael Telgkamp voted on patch set 2 CR +1 V +1 06/13/24, 11:29

  8. Andreas Nedbal voted on patch set 2 CR +1 V +1 06/13/24, 11:38

  9. Jasmina Ließmann voted on patch set 2 CR +1 V +1 06/13/24, 11:40

  10. Oli Bartsch voted on patch set 2 CR +2 V +2 06/13/24, 13:10

  11. Oli Bartsch merged patch set 3 06/13/24, 13:10