84686[BUGFIX] Add aria-label to the selection options toggle button
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Jasmina Ließmann +1
- Andreas Nedbal +1
- Michael Telgkamp +1
-
Verified V +2 Done
- Oli Bartsch +2
- Jasmina Ließmann +1
- Andreas Nedbal +1
- Michael Telgkamp +1
- core-ci +1 CI
Issues 1
Files 11
- Build/Sources/TypeScript/workspaces/renderable/record-table.ts+1 −1
- typo3/sysext/backend/Classes/Form/Element/SelectCheckBoxElement.php6+8 −7
- typo3/sysext/backend/Classes/RecordList/DatabaseRecordList.php+1 −1
- typo3/sysext/core/Resources/Private/Language/locallang_core.xlf+3 −0
- typo3/sysext/filelist/Classes/FileList.php+1 −1
- typo3/sysext/reactions/Resources/Private/Templates/Management/Overview.html+1 −1
- typo3/sysext/recycler/Resources/Private/Templates/RecyclerModule.html+1 −1
- typo3/sysext/redirects/Resources/Private/Templates/Management/Overview.html+1 −1
- typo3/sysext/scheduler/Resources/Private/Partials/TaskList.html+1 −0
- typo3/sysext/webhooks/Resources/Private/Templates/Management/Overview.html+1 −1
- typo3/sysext/workspaces/Resources/Public/JavaScript/renderable/record-table.js+1 −1
Review log 911
-
Oli Bartsch uploaded patch set 1 06/13/24, 10:14
-
core-ci voted on patch set 1 V +1 06/13/24, 10:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59457
-
Michael Telgkamp commented on patch set 1 CR -1 06/13/24, 10:32
Some additional improvements suggested.SelectCheckBoxElement.php:308As $languageService is available it should probably be used here, too.SelectCheckBoxElement.php:332As $languageService is available it should probably be used here, too.SelectCheckBoxElement.php:338As $languageService is available it should probably be used here, too. -
Oli Bartsch uploaded patch set 2
CR -1V +106/13/24, 10:41 -
Oli Bartsch commented on patch set 2 06/13/24, 10:47
SelectCheckBoxElement.php:308ReplyDoneSelectCheckBoxElement.php:332ReplyDoneSelectCheckBoxElement.php:338ReplyDone -
core-ci voted on patch set 2 V +1 06/13/24, 10:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59460
-
Michael Telgkamp voted on patch set 2 CR +1 V +1 06/13/24, 11:29
-
Andreas Nedbal voted on patch set 2 CR +1 V +1 06/13/24, 11:38
-
Jasmina Ließmann voted on patch set 2 CR +1 V +1 06/13/24, 11:40
-
Oli Bartsch voted on patch set 2 CR +2 V +2 06/13/24, 13:10
-
Oli Bartsch merged patch set 3 06/13/24, 13:10