Review 12.4 Merged

84687[BUGFIX] Show element specific labels in linkvalidator report

Christian Kuhn CR +2 V +2 Easy +7 −5 updated 06/13/24, 11:12

Commit message

The link validator "missing links" report shows the title of the
field which contains the missing link.

This title is loaded from `TCA.$table.columns.$field.label`,
but it is possible to use content-element specific labels in
`TCA.$table.types.$contenttype.columnsOverrides.*.label`,
and this is not supported by the validator.

The patch first tries to load the overridden label and
then falls back to the normal TCA column label.

This fixes titles of elements generated by the "mask" extension,
which only sets labels via overrides.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Christian Kuhn uploaded patch set 1 06/13/24, 10:46

  2. core-ci voted on patch set 1 V +1 06/13/24, 10:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59462

  3. Christian Kuhn voted on patch set 1 CR +2 V +2 06/13/24, 11:12

  4. Christian Kuhn merged patch set 2 06/13/24, 11:12