84688[BUGFIX] Add ARIA label reference to close button in modal windows
Commit message
Review
-
Code review CR +2 Done
- Benjamin Kott +2
- Michael Telgkamp +1
-
Verified V +2 Done
- Benjamin Kott +2
- Markus Timtner +1
- Michael Telgkamp +1
- core-ci +1 CI
Issues 1
Files 2
Review log 3548
Show 1623 earlier messages
-
Christian Rath-Ulrich uploaded patch set 1 06/13/24, 12:11
-
core-ci voted on patch set 1 V +1 06/13/24, 12:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59478
-
morgane garcia updated the commit message in patch set 2
V +106/13/24, 13:29 -
core-ci voted on patch set 2 V +1 06/13/24, 13:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59494
-
morgane garcia voted on patch set 2 CR +1 V +1 06/13/24, 13:43
-
Andreas Kienast commented on patch set 2 CR -1 06/13/24, 13:49
-
Christian Rath-Ulrich commented on patch set 2 06/13/24, 14:25
modal.ts:168ReplyThat would be perfect, the little I know about TypeScript is unfortunately not enough to get that done. -
Christian Rath-Ulrich uploaded patch set 3
CR +1V +107/16/24, 22:40 -
Christian Rath-Ulrich commented on patch set 3 07/16/24, 22:42
modal.ts:168ReplyThink I got it -
core-ci voted on patch set 3 V -1 07/16/24, 22:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61652
-
Andreas Kienast commented on patch set 3 CR -1 07/17/24, 05:34
modal.ts:154This has a poor entropy. I suggest to use `Math.random().toString(36).substring(2, 12)` instead. -
Christian Rath-Ulrich uploaded patch set 4
CR -1V -107/17/24, 13:15 -
Christian Rath-Ulrich commented on patch set 4 07/17/24, 13:16
modal.ts:154ReplyDone -
core-ci voted on patch set 4 V -1 07/17/24, 13:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61686
-
Christian Rath-Ulrich rebased onto patch set 5
V -107/18/24, 06:46 -
core-ci voted on patch set 5 V +1 07/18/24, 06:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61718
-
Andreas Kienast updated the commit message in patch set 6
V +107/18/24, 06:59 -
Benjamin Kott commented on patch set 6 CR -2 07/18/24, 07:06
that seems to be wrong, how can the close button get the label from the title? this would override the label from the close button and sets the label for the close button to the title of the modal window? am i missing something here? -
core-ci voted on patch set 6 V +1 07/18/24, 07:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61719
-
Benni Mack updated the commit message in patch set 7
V +110/18/24, 13:38Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
core-ci voted on patch set 7 V -1 10/18/24, 22:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68014
-
Christian Rath-Ulrich commented on patch set 7 10/21/24, 12:02
Reply
As far as I know, the aria labeled by does not overwrite the content of the element but only provides a context. maybe @michael.telgkamp@mindscreen.de can validate this if the labeled by overwrites that, the change is so rubbish -
Oli Bartsch abandoned the change 12/18/24, 11:09
I'm abandoning this since there's been no activity on this for several months. If you'd like to pick it up again in the future, feel free to restore it anytime. Thanks!
-
Benjamin Franzke restored the change 12/19/24, 09:26
-
Benni Mack marked it work in progress 03/28/25, 14:13
-
Christian Rath-Ulrich uploaded patch set 8
V -105/21/25, 12:55Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
core-ci voted on patch set 8 V -1 05/21/25, 13:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79305
-
Christian Rath-Ulrich uploaded patch set 9
V -105/21/25, 14:35Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
core-ci voted on patch set 9 V +1 05/21/25, 14:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79312
-
Christian Rath-Ulrich commented on patch set 9 05/21/25, 14:57
This change is ready for review.Reply
After talking to an expert again. The patch was revised again and I follow your suggestion. -
Christian Rath-Ulrich uploaded patch set 10
V +105/21/25, 15:04Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
core-ci voted on patch set 10 V +1 05/21/25, 15:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79319
-
Benjamin Kott commented on patch set 10 CR -2 09/09/25, 12:06
this patch still feels wrong, we are just moving the already available label for screen readers to the button. we should talk about this in person / call maybe. -
Christian Rath-Ulrich uploaded patch set 11
V +109/10/25, 13:01Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
core-ci voted on patch set 11 V +1 09/10/25, 13:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84777
-
Michael Telgkamp commented on patch set 11 CR -1 09/10/25, 14:21
Having only the additional text is fine for me, the two other changes should be reverted.modal.ts:129The additional space character here should be removedmodal.ts:172As far as I see, the class should still start with "h4 t3js..." and not " h4t3js..."modal.ts:176So the current change in Text is to add "${this.modalTitle}" to the visually-hidden `span` inside the button. -
Christian Rath-Ulrich uploaded patch set 12
CR -1V +109/10/25, 15:44Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
Christian Rath-Ulrich commented on patch set 11 09/10/25, 15:46
Reply
yes you are rightmodal.ts:129Replyfixedmodal.ts:172Replyfixedmodal.ts:176Replyyes to give some context -
Michael Telgkamp voted on patch set 12 CR +1 V +1 09/10/25, 15:49
-
core-ci voted on patch set 12 V +1 09/10/25, 15:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84788
-
Simon Schaufelberger commented on patch set 12 09/10/25, 15:50
modal.ts:172please remove the extra whitespace -
Christian Rath-Ulrich uploaded patch set 13
CR +1V +109/10/25, 16:48Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
Christian Rath-Ulrich commented on patch set 13 09/10/25, 16:49
modal.ts:172ReplyDone -
core-ci voted on patch set 13 V +1 09/10/25, 16:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84790
-
Michael Telgkamp commented on patch set 13 CR +1 V +1 09/11/25, 07:30
Only change in Patchset 13 is removing the one additional space left in the modal.ts file, that did not make a difference in the resulting modal.js, so I still give my +1s -
Markus Timtner voted on patch set 13 V +1 10/14/25, 13:26
-
Benjamin Kott voted on patch set 13 CR +2 V +2 10/21/25, 10:35
-
Benjamin Kott merged patch set 14 10/21/25, 10:44
modal.ts:168