Review main Abandoned

84690[TASK] Unify display of sorting button in "Redirects"

morgane garcia CR -1 V 0 Easy +19 −9 updated 09/29/26, 09:54

Commit message

Set the same button like the others "sorting" buttons.
The click on the button sort the table of list of the redirects.
The same button was hadding on the 3 first columns
(Source Domain column, Source Path column and Target column)

Review

  • Code review CR -1
    • Stefan Bürk -1
  • Verified V 0
    • core-ci +1 CI

Issues 1

Files 3

Review log 79

  1. morgane garcia uploaded patch set 1 06/13/24, 12:42

  2. core-ci voted on patch set 1 V +1 06/13/24, 12:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59481

  3. morgane garcia uploaded patch set 2 V +1 06/13/24, 14:02

  4. core-ci voted on patch set 2 V +1 06/13/24, 14:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59502

  5. Stefan Bürk commented on patch set 2 CR -1 06/13/24, 15:36

    First, the start field sorting is not displayed correctly. Secondly, and the most important one, clicking on the icon switches the icon but does not reload the view with the changed sorting/field and therefore not loading the "whole" recordset resorted (and jumped to page one). Seems to be a "in view" solution only, which is not suitable for the redirect module. I'm okay with unifing the icon, but the behaviour must not change here.
  6. Jasmina Ließmann commented on patch set 2 06/14/24, 08:32

    Reply Unresolved

    The inital goal of the patch was to use the same sorting functionality as in other modules (like lists or indexing) and not just to swap the icon. The user should experience the same UX across modules.
  7. Benni Mack wrote 03/22/25, 16:53

    Topic set to redirects
  8. Jasmina Ließmann wrote 06/22/26, 11:33

    Removed cc Jasmina Ließmann.
  9. Benni Mack abandoned the change 09/29/26, 09:54

    this change is in core already (also in v14.3), so I will drop this change.