Review main Merged

84695[FEATURE] Allow editing metadata of multiple files in "columns only" mode

Oli Bartsch CR +2 V +2 Normal +74 −7 updated 06/14/24, 17:08

Commit message

A new multi record selection option is
added to the filelist, which allows to
edit the metadata of multiple records
while respecting the currently defined
columns list.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Garvin Hicking +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Garvin Hicking +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 1114

  1. Oli Bartsch uploaded patch set 1 06/13/24, 13:07

  2. core-ci voted on patch set 1 V +1 06/13/24, 13:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59488

  3. Garvin Hicking uploaded patch set 2 V +1 06/13/24, 13:57

    RST
  4. Garvin Hicking commented on patch set 2 CR +1 V +1 06/13/24, 14:02

    Works pretty well. Just one minor thought about the button label, non-blocking.

    locallang_mod_file_list.xlf:19

    When seing "Edit Metadata" next to "Edit selected columns" I wonder if everyone directly understands the difference between "selected" (multiple files selected) and "selected columns" (selected columns of also selecteed files). How about: "Edit all metadata" "Edit column-specific metadata" (Yes, I think this proposal is too long. Not "blocking" this of course if everyone else thinks this is a non-issue)
  5. core-ci voted on patch set 2 V +1 06/13/24, 14:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59501

  6. Oli Bartsch uploaded patch set 3 CR +1 V +1 06/14/24, 12:51

  7. Oli Bartsch commented on patch set 3 06/14/24, 12:53

    locallang_mod_file_list.xlf:19 Reply

    Rephrased it to make it ,more clear. Actually the label is now even shorter.
  8. core-ci voted on patch set 3 V +1 06/14/24, 12:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59602

  9. Garvin Hicking voted on patch set 3 CR +1 V +1 06/14/24, 13:09

  10. Christian Kuhn voted on patch set 3 CR +1 V +1 06/14/24, 13:17

  11. Jochen Roth voted on patch set 3 CR +1 V +1 06/14/24, 13:39

  12. Oli Bartsch voted on patch set 3 CR +2 V +2 06/14/24, 16:04

  13. Oli Bartsch merged patch set 4 06/14/24, 16:04

  14. Simon Schaufelberger commented on patch set 4 06/14/24, 17:08

    Feature-104095-EditSpecificColumnsOfMultipleFilesInFilelistModule.rst:14 Unresolved

    the only once