84697[BUGFIX] Convert fixed font sizes to relative units
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Benjamin Franzke +1
-
Verified V +2 Done
- Benni Mack +2
- Benjamin Franzke +1
- core-ci +1 CI
Issues 2
Files 12
- Build/Sources/Sass/component/_dropdown.scss+7 −6
- Build/Sources/Sass/dashboard/_widget_number.scss+1 −1
- Build/Sources/Sass/typo3/_login_screen.scss+1 −1
- Build/Sources/Sass/adminpanel.scss+0 −1
- Build/Sources/Sass/workspace.scss+4 −4
- typo3/sysext/adminpanel/Resources/Public/Css/adminpanel.css+1 −1
- typo3/sysext/backend/Resources/Public/Css/backend.css+4 −4
- typo3/sysext/dashboard/Resources/Public/Css/dashboard.css+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Debug/RenderViewHelper.php2+1 −1
- typo3/sysext/frontend/Classes/Http/RequestHandler.php+1 −1
- typo3/sysext/workspaces/Classes/Middleware/WorkspacePreview.php+1 −1
- typo3/sysext/workspaces/Resources/Public/Css/preview.css+1 −1
Review log 2236
Show 711 earlier messages
-
Christian Rath-Ulrich uploaded patch set 1 06/13/24, 13:31
-
Christian Rath-Ulrich updated the commit message in patch set 2 06/13/24, 13:36
-
core-ci voted on patch set 1 V +1 06/13/24, 13:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59495
-
core-ci voted on patch set 2 V +1 06/13/24, 13:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59497
-
Benni Mack updated the commit message in patch set 3
V +110/18/24, 13:32 -
core-ci voted on patch set 3 V -1 10/18/24, 22:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67991
-
Simon Schaufelberger uploaded patch set 4
V -112/06/24, 13:06 -
core-ci voted on patch set 4 V -1 12/06/24, 13:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70708
-
Simon Schaufelberger commented on patch set 4 12/06/24, 13:38
@christian@rath-ulrich.de can you please have a look at the broken CI -
Christian Rath-Ulrich commented on patch set 4 12/18/24, 12:39
Reply
I think there is a rebase needed -
Benni Mack rebased onto patch set 5
V -101/10/25, 11:58
-
core-ci voted on patch set 5 V -1 01/10/25, 12:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72207
-
Benni Mack marked it work in progress 02/18/25, 15:38
-
Christian Rath-Ulrich uploaded patch set 6
V -105/21/25, 11:17 -
core-ci voted on patch set 6 V -1 05/21/25, 11:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79294
-
Christian Rath-Ulrich uploaded patch set 7
V -105/21/25, 14:51 -
core-ci voted on patch set 7 V -1 05/21/25, 15:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79318
-
Christian Rath-Ulrich commented on patch set 7 05/21/25, 15:06
This change is ready for review.Reply
Done -
Christian Rath-Ulrich rebased onto patch set 8
V -105/27/25, 10:15 -
core-ci voted on patch set 8 V -1 05/27/25, 10:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79551
-
Benjamin Franzke uploaded patch set 9
V -110/30/25, 14:03 -
core-ci voted on patch set 9 V -1 10/30/25, 14:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88150
-
Benjamin Franzke uploaded patch set 10
V -111/11/25, 15:04 -
core-ci voted on patch set 10 V +1 11/11/25, 15:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89025
-
Jasmina Ließmann rebased onto patch set 11
V +111/13/25, 12:05 -
core-ci voted on patch set 11 V +1 11/13/25, 12:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89488
-
Benjamin Franzke uploaded patch set 12
V +111/13/25, 14:47 -
core-ci voted on patch set 12 V -1 11/13/25, 14:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89526
-
Benni Mack uploaded patch set 13
V -111/14/25, 06:56 -
Benni Mack commented on patch set 13 11/14/25, 07:03
RenderViewHelper.php:96I think we should tell the contributors when to use "em" and "rem". -
core-ci voted on patch set 13 V +1 11/14/25, 07:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89652
-
Benjamin Franzke rebased onto patch set 14
V +111/14/25, 07:40 -
Benjamin Franzke commented on patch set 14 11/14/25, 07:40
RenderViewHelper.php:96ReplyThanks for bringing this up. Yes, I should have documented it, when I changed Christian's `rem` units to `em` for the parts that are emitted into the frontend output, instead of the TYPO3 backend. I've updating the commit message with a note regarding the reasoning. -
core-ci voted on patch set 14 V +1 11/14/25, 07:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89656
-
Benni Mack voted on patch set 14 CR +2 V +2 11/14/25, 09:47
-
Benni Mack merged patch set 15 11/14/25, 09:47