Review main Merged

84697[BUGFIX] Convert fixed font sizes to relative units

Christian Rath-Ulrich CR +2 V +2 Easy +23 −23 updated 11/14/25, 09:47

Commit message

In continuation of #104044 fixed font size definition on
certain components are migrated to use relative font units.

Note that CSS that is emitted to the TYPO3 frontend uses
`em` instead of `rem` in order to avoid putting a demand on
the font size that is defines on the frontend specific HTML
tag styling. Instead the current font size of the context
where the respective element is rendered is taken into account
for relative sizing.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Benjamin Franzke +1
  • Verified V +2 Done
    • Benni Mack +2
    • Benjamin Franzke +1
    • core-ci +1 CI

Issues 2

Files 12

Review log 2236

Show 711 earlier messages
  1. Christian Rath-Ulrich uploaded patch set 1 06/13/24, 13:31

  2. Christian Rath-Ulrich updated the commit message in patch set 2 06/13/24, 13:36

  3. core-ci voted on patch set 1 V +1 06/13/24, 13:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59495

  4. core-ci voted on patch set 2 V +1 06/13/24, 13:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59497

  5. Benni Mack updated the commit message in patch set 3 V +1 10/18/24, 13:32

  6. core-ci voted on patch set 3 V -1 10/18/24, 22:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67991

  7. Simon Schaufelberger uploaded patch set 4 V -1 12/06/24, 13:06

  8. core-ci voted on patch set 4 V -1 12/06/24, 13:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70708

  9. Simon Schaufelberger commented on patch set 4 12/06/24, 13:38

    @christian@rath-ulrich.de can you please have a look at the broken CI
  10. Christian Rath-Ulrich commented on patch set 4 12/18/24, 12:39

    Reply

    I think there is a rebase needed
  11. Benni Mack rebased onto patch set 5 V -1 01/10/25, 11:58

  1. core-ci voted on patch set 5 V -1 01/10/25, 12:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72207

  2. Benni Mack marked it work in progress 02/18/25, 15:38

  3. Christian Rath-Ulrich uploaded patch set 6 V -1 05/21/25, 11:17

  4. core-ci voted on patch set 6 V -1 05/21/25, 11:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79294

  5. Christian Rath-Ulrich uploaded patch set 7 V -1 05/21/25, 14:51

  6. core-ci voted on patch set 7 V -1 05/21/25, 15:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79318

  7. Christian Rath-Ulrich commented on patch set 7 05/21/25, 15:06

    This change is ready for review.

    Reply

    Done
  8. Christian Rath-Ulrich rebased onto patch set 8 V -1 05/27/25, 10:15

  9. core-ci voted on patch set 8 V -1 05/27/25, 10:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79551

  10. Benjamin Franzke uploaded patch set 9 V -1 10/30/25, 14:03

  11. core-ci voted on patch set 9 V -1 10/30/25, 14:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88150

  12. Benjamin Franzke uploaded patch set 10 V -1 11/11/25, 15:04

  13. core-ci voted on patch set 10 V +1 11/11/25, 15:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89025

  14. Jasmina Ließmann rebased onto patch set 11 V +1 11/13/25, 12:05

  15. core-ci voted on patch set 11 V +1 11/13/25, 12:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89488

  16. Benjamin Franzke uploaded patch set 12 V +1 11/13/25, 14:47

  17. core-ci voted on patch set 12 V -1 11/13/25, 14:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89526

  18. Benni Mack uploaded patch set 13 V -1 11/14/25, 06:56

  19. Benni Mack commented on patch set 13 11/14/25, 07:03

    RenderViewHelper.php:96

    I think we should tell the contributors when to use "em" and "rem".
  20. core-ci voted on patch set 13 V +1 11/14/25, 07:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89652

  21. Benjamin Franzke rebased onto patch set 14 V +1 11/14/25, 07:40

  22. Benjamin Franzke commented on patch set 14 11/14/25, 07:40

    RenderViewHelper.php:96 Reply

    Thanks for bringing this up. Yes, I should have documented it, when I changed Christian's `rem` units to `em` for the parts that are emitted into the frontend output, instead of the TYPO3 backend. I've updating the commit message with a note regarding the reasoning.
  23. core-ci voted on patch set 14 V +1 11/14/25, 07:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89656

  24. Benni Mack voted on patch set 14 CR +2 V +2 11/14/25, 09:47

  25. Benni Mack merged patch set 15 11/14/25, 09:47