84700[BUGFIX] Check open graph to decide if twitter:card should be added
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Garvin Hicking +1
-
Verified V +2 Done
- Christian Kuhn +2
- Garvin Hicking +1
- core-ci +1 CI
Issues 2
Files 2
Review log 1216
-
Kevin Appelt uploaded patch set 1 06/13/24, 14:06
-
core-ci voted on patch set 1 V +1 06/13/24, 14:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59503
-
Garvin Hicking commented on patch set 1 CR +1 V +1 06/13/24, 14:13
Good catch, thanks for following up on this. Due to "twitter:card" being required to show content (I did not know this; I thought it would just affect the display, and also 'summary' would be the default, so the tag would mostly make sense when NOT picking 'summary'). -
Georg Ringer commented on patch set 1 06/13/24, 14:13
please also adopt the rst -
Georg Ringer voted on patch set 1 CR -1 06/13/24, 14:14
-
Georg Ringer uploaded patch set 2
CR +1V +106/19/24, 20:22 -
Garvin Hicking voted on patch set 2 CR +1 V +1 06/19/24, 20:23
-
core-ci voted on patch set 2 V +1 06/19/24, 20:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59866
-
Christian Kuhn updated the commit message in patch set 3
CR +1V +106/20/24, 16:27 -
Christian Kuhn rebased onto patch set 4 06/20/24, 16:27
-
Christian Kuhn voted on patch set 4 CR +1 V +1 06/20/24, 16:29
-
core-ci voted on patch set 3 V +1 06/20/24, 16:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59932
-
Garvin Hicking voted on patch set 4 CR +1 V +1 06/20/24, 16:33
-
core-ci voted on patch set 4 V +1 06/20/24, 16:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59933
-
Christian Kuhn voted on patch set 4 CR +2 V +2 06/20/24, 16:56
-
Christian Kuhn merged patch set 5 06/20/24, 16:56