Review main Merged

84701[BUGFIX] Revert breaking change in BackendLayout class

Benni Mack CR +2 V +2 Easy +3 −2 updated 06/13/24, 18:22

Commit message

While cleaning up BackendLayout code, a
"declare(strict_types=1);" line was introduced,
which made existing v13-compatible PHP code
break. This is now reverted in order to smoothen
the upgrade path to v13 LTS.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Stefan Bürk +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Stefan Bürk +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 914

  1. Benni Mack uploaded patch set 1 06/13/24, 16:11

  2. Christian Kuhn commented on patch set 2 06/13/24, 16:13

    Published edit on patch set 1.
  3. Christian Kuhn voted on patch set 2 CR +1 V +1 06/13/24, 16:14

  4. core-ci voted on patch set 1 V -1 06/13/24, 16:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59512

  5. core-ci voted on patch set 2 V -1 06/13/24, 16:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59513

  6. Benni Mack commented on patch set 3 CR +1 V +1 06/13/24, 17:30

    Published edit on patch set 2.
  7. core-ci voted on patch set 3 V -1 06/13/24, 17:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59521

  8. Christian Kuhn uploaded patch set 4 V -1 06/13/24, 17:47

  9. core-ci voted on patch set 3 V -1 06/13/24, 17:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59521

  10. core-ci voted on patch set 4 V +1 06/13/24, 17:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59525

  11. Christian Kuhn voted on patch set 4 CR +1 V +1 06/13/24, 18:14

  12. Stefan Bürk voted on patch set 4 CR +1 V +1 06/13/24, 18:17

  13. Georg Ringer voted on patch set 4 CR +2 V +2 06/13/24, 18:22

  14. Georg Ringer merged patch set 5 06/13/24, 18:22